Conversation
…ileSystem
_open only rejected paths in pseudo_dirs (explicit dirs from makedirs),
so a path that is a directory only because files live under it (the
common case after pipe/touch) could be silently opened as a file,
shadowing every path beneath it.
>>> m.pipe('/dir/file', b'data')
>>> m.open('/dir', 'wb') # used to succeed
>>> m.glob('/dir/**') # -> [] afterwards, file unreachable
Mirrors the directory check info() already does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_openonly rejected paths inpseudo_dirs(explicit directories created viamakedirs), so a path that is a directory only because files live under it — the common case afterpipe/touch— could be silently opened as a file, shadowing everything beneath it:Fix mirrors the directory check
info()already does, and only checks the store (notisdir) so it doesn't add an extra call on the commonput/pipepath.Added a regression test (
test_open_implicit_directory_raises) coveringrb/wb/ab; confirmed it fails on master without the fix.🤖 Generated with Claude Code