Create test API keys through the test server endpoint - #1248
Merged
Merged
Conversation
The integration suite created API keys with HTTP Basic authentication, which hex.pm is removing from its API. Keys are now created through hexpm's test-only POST /api/key endpoint, so the suite needs a hexpm that has it. Hex.API.Client no longer accepts user/pass options since nothing passes them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The integration suite created API keys with HTTP Basic authentication, which hex.pm is removing from its API. Keys are now created through hexpm's test-only
POST /api/keyendpoint from hexpm/hexpm#1966, so CI passes once that is on hexpm main.Hex.API.Clientno longer acceptsuser/passoptions since nothing passes them.