Add hard cancel to CONDITION_PENDING - #777
Merged
Merged
Conversation
jakub-id
requested review from
JanisSaldabols and
adamdickmeiss
as code owners
September 22, 2026 18:46
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
Restore the nil-ServiceInfo regression test case in action_test.go.
Review effort: Lite
Findings: None
What changed in this PR
Adds a hard cancel-request action for CONDITION_PENDING, with updated documentation and test coverage.
Changes:
- Adds the cancellation action and transition.
- Documents cancellation behavior.
- Expands action mapping and execution tests.
| File | Summary |
|---|---|
misc/state-models.yaml |
Adds hard cancellation from CONDITION_PENDING. |
broker/README.md |
Documents cancellation semantics. |
broker/patron_request/service/action_test.go |
Tests cancellation across states and service types; retain a separate nil-ServiceInfo regression case. |
broker/patron_request/service/action_mapping_test.go |
Updates expected action mappings. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.