Repository navigation
Operator construction, application rewrite - #418
Open
a-alveyblanc wants to merge 10 commits into
Open
a-alveyblanc wants to merge 10 commits into
a-alveyblanc wants to merge 10 commits into
Conversation
Owner
|
I like the direction. Could you investigate the failures? |
Contributor
Author
|
Patched example/test failures. Remaining basedpyright failure is due to warnings. I'll address those sometime this week. |
Contributor
Author
|
@inducer Ready for a look. basedpyright failure is due to warnings that come from weird typing interactions between libraries as we discussed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors
op.pyso that operator application is more unified and adds an explicit file for constructing operators. Adds support for sum factorization with tensor-product discretizations.reference_mass_matrix,reference_face_mass_matrix, andreference_inverse_mass_matrixare marked as deprecated since they are public methods (nothing in grudge uses them anymore, but I thought this was the safest option for compatibility).bilinear_forms.pyand forms all operators using quadratureop.pyaround a general operator application routineweak_local_gradandweak_local_divuseweak_local_d_dxto compute their respective results