Conversation
afk11
force-pushed
the
user-2fa-no-fillable
branch
from
September 8, 2026 19:19
ac6c214 to
d61bb2e
Compare
afk11
changed the title
…ethod into a method. also, remove fillable, add boolean cast to 'enabled', and add strict_types=1 and define isEnabled()
afk11
force-pushed
the
user-2fa-no-fillable
branch
from
September 8, 2026 19:31
d61bb2e to
fd9bcc9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
User2FArecord is created and the only change to affect it is to later set enabled to true. It doesn't need fillable properties, so refactor them out.User2FA::setupForUserstatic factory method$this->enabled=trueupdate into anenablemethodisEnabled()