Timeout middleware milliseconds - #3064
Merged
kubernetes-prow[bot] merged 5 commits intoSep 24, 2026
Merged
kubernetes-prow[bot] merged 5 commits into
kubernetes-prow[bot] merged 5 commits into
Conversation
kubernetes-prow
Bot
added
do-not-merge/work-in-progress
kubernetes-prow
Bot
added
the
approved
davidgamero
force-pushed
the
timeout-middleware-milliseconds
branch
from
September 22, 2026 16:27
566e7ce to
7e11cba
Compare
davidgamero
marked this pull request as ready for review
September 23, 2026 01:43
kubernetes-prow
Bot
removed
the
do-not-merge/work-in-progress
Contributor
|
/lgtm |
kubernetes-prow
Bot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, davidgamero The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
requestTimeoutMiddleware(milliseconds)andsetRequestTimeoutOptions(milliseconds, options?)fixes #1613.
builds on call-time middleware from #2275 and abort signal support from #2583. this exposes the middleware approach discussed in #2430 instead of adding a timeout parameter to
makeApiClient().this is an absolute request deadline, not an inactivity timeout. watch inactivity remains handled separately by #3022.
ai disclosure: opencode and gpt6