Make sieMin/sieMax pass through systemunits - #658
Merged
Merged
Conversation
Yurlungur
approved these changes
Sep 21, 2026
Yurlungur
left a comment
Collaborator
There was a problem hiding this comment.
I'm happy to merge this now. But we should consider adding sieMin and sieMax to the general EOS API. We could add a base implementation that just returns sensible bounds... Probably sie(rho=rho_at_Pmin, T=0) and +infinity and we can override.
Comment on lines
+295
to
+300
| // Pass-throughs for the table bounds accessors some models provide, | ||
| // e.g., SpinerEOS and StellarCollapse. These are not part of the | ||
| // EosBase contract, so they are only well formed when the underlying | ||
| // EOS provides them. Since UnitSystem is a template, these bodies are | ||
| // only instantiated when called, so UnitSystem<T> remains valid for a | ||
| // T without these accessors until one of them is actually used. |
Collaborator
There was a problem hiding this comment.
I'm not sure how I feel about this being implicitly defined like this. I think it's quite confusing even with the comment.
In particular, the error message from a failed compilation will be very confusing for a new developer. Perhaps instead, we could use an if constexpr here that checks if the function exists and otherwise static assert?
buechlerm
commented
Sep 21, 2026
Yurlungur
approved these changes
Sep 21, 2026
Yurlungur
approved these changes
Sep 21, 2026
Co-authored-by: Jonah Miller <jonah.maxwell.miller@gmail.com>
Collaborator
|
@buechlerm from my perspective this is good to go. |
adamdempsey90
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
make formatcommand after configuring withcmake.plan_historiesfolder, with a filename the same as the MR number.If preparing for a new release, in addition please check the following: