feat: only offer a Less alpha that ships the browser bundle - #33
Merged
Merged
Conversation
The alpha entry in the version switcher loads dist/less-browser-dev.js from the CDN. Alphas published before 5.0.0-alpha.3 do not include that file, so offering them only produced a load failure. Like the Less benchmark runner's per-file minimum versions, gate the entry on the first alpha that actually ships the bundle, using a prerelease-aware compare.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The experimental alpha entry loads
dist/less-browser-dev.jsfrom jsDelivr. Alphas published before5.0.0-alpha.3do not include that file, so selecting them only produced a load failure.This gates the entry on the first alpha that ships the bundle. The existing option gates compare the numeric release core only (an alpha counts as its release line), so a small prerelease-aware
atLeastis added for this one check:5.0.0-alpha.2is excluded,5.0.0-alpha.3, later alphas and the5.0.0release are included.Same idea as the Less benchmark runner's per-file minimum versions: only offer what the selected version can actually run.