Repository navigation
Conversation
Discard the safety-check helper's result instead of returning a reference to its local parameter, avoiding optimized GDC warnings. Test indexed increment, decrement, and reference-return behavior for ubyte, ushort, uint, and ulong. Fixes libmir#483 AI-Assisted-By: Codex (GPT-6 Astra Medium)
This was referenced Oct 5, 2026
Contributor
Author
|
Only failure is Circle CI, which is unrelated to this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The safety-check helper for indexed unary operations returns
auto reffrom a value passed by value. Forubyteandushort, optimized GDC 14 and 15 diagnose this as returning a reference to a local parameter, causing builds with-Werrorto fail.Change the helper to return
voidand discard the expression result. It still checks that the operation is@safe; the actual indexed operation and its reference-return behavior remain unchanged.Add tests covering increment, decrement, and assignment through the returned reference for
ubyte,ushort,uint, andulong.Validation:
-Wall -Werrorand runs successfully on both GDC versions.Fixes #483.