Skip to content

docs: add versioned plugin advisories for issue 1396 - #3387

Open
eleshar wants to merge 5 commits into
developfrom
docs/plugin-advisories-1396
Open

eleshar wants to merge 5 commits into
developfrom
docs/plugin-advisories-1396

Conversation

@eleshar

@eleshar eleshar commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

Summary

Implements issue #1396: single versioned document holding the plugin advisories (docs/PLUGIN_ADVISORIES.md, review owner + last-reviewed date in header).

Honesty notes (verified, not assumed)

  • Only 2 of 13 Section 1 replacements are shipped (cachebuster, change-mail-sender — verified in ls-starter-plugin/inc/). Everything else is marked planned with the tracking issue where one exists (SVG → ls-starter-plugin#3, mail sender → ls-starter-plugin#2) or an explicit 'no tracking issue yet' where none does. The issue text describes the target state; the doc does not claim it as current.
  • Section 2 and 4 each carry stated reasons with cited sources (GF docs, MDN Baseline pages, Google Tag Platform docs, Cloudflare APO docs, nginx guidance), including the required newsletter REST and dialog reference implementations.
  • Section 3 gives a reason per retained plugin.
  • Caveats researched online: phpmailer_init fires after core setFrom(); @view-transition is not Baseline (progressive enhancement only); gform_disable_css breaks conditional logic per GF docs.

Acceptance criteria mapping

  • Document committed + linked: this PR (register link pending — no approved plugin register exists in this repo yet; recommend follow-up).
  • Every advisory names replacement/alternative: yes, table + implementations.
  • Implementing issue/PR links: shipped items link code + registry; planned items link tracking issues or state none exists.
  • Reasons in sections 2 and 4: yes. Owner + last-reviewed date: yes.

Verification

  • Changelog quality gate 68/68 pass; gate scripts pass; frontmatter validator reports zero errors for the new file (remaining errors pre-existing elsewhere); docs/ excluded from markdownlint per repo config.
  • New branch validates clean against branch-naming policy.

@coderabbitai

coderabbitai Bot commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 34 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository: lightspeedwp/.github/.coderabbit.yml

Review profile: CHILL

Plan: Advanced

Run ID: b9617e74-1a49-44de-ad67-f8f153a33edc

📥 Commits

Reviewing files that changed from the base of the PR and between d1424a4 and ebdf7ba.

📒 Files selected for processing (3)
  • CHANGELOG.md
  • docs/PLUGIN_ADVISORIES.md
  • docs/PLUGIN_REGISTER.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

📋 Changelog Quality Validation

Summary

Metric Count
✅ Passing 74
⚠️ Warnings 0
❌ Failing 0
🆕 New failures in this PR 0
📦 Pre-existing failures 0

Status

Validation PASSED - No new failures introduced by this PR.

No action required.

@github-actions

Copy link
Copy Markdown
Contributor

PR Template Routing

Branch Type: docs
Scope: plugin-advisories-1396
Template: pr_docs.md
Labels Applied: type:docs

This PR was automatically routed based on the branch naming strategy.

@mergify

mergify Bot commented Sep 19, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@ashleyshaw
ashleyshaw requested a review from krugazul September 21, 2026 05:15
@eleshar

eleshar commented Sep 21, 2026

Copy link
Copy Markdown
Contributor Author

Heads-up: this PR body does not include the sections from its routed template (docs/ → pr_feature.md). Missing: ## Linked issues, ## Changelog. Please copy those sections into the body with real content. The template-routing check now fails on the next push when required sections are missing or left as template boilerplate.

@krugazul krugazul left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eleshar we will no longer be using the starter plugin and theme. We are generating our plugins and themes from the following 2 tools.

https://github.com/lightspeedwp/block-plugin-scaffold
https://github.com/lightspeedwp/block-theme-scaffold

@ashleyshaw ashleyshaw modified the milestones: Backlog, v1.1 Sep 22, 2026
@ashleyshaw ashleyshaw self-assigned this Sep 22, 2026
@ashleyshaw ashleyshaw modified the milestones: v1.6, v1.1 Sep 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants