run CI on pull requests - #162
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review. 📝 WalkthroughWalkthroughThe test workflow now runs on pushes to ChangesTest workflow triggers
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~5 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The requested CI triggers are configured, and the lint check remains intact; no actionable merge risk is identified. Architecture SummaryArchitecture risk: 🔵 Low · up to The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency. Changed systems: None identified. Architecture concerns Review detailsBefore / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Motivation
CI only runs on
push. When a PR comes from a fork, the contributor pushes to their fork, so CI runs there and never reports checks on the PR here.lintis required onmain, so a fork PR stays blocked even after it's approved. Example: #161 is approved, butlintis stuck on "Waiting for status to be reported".Changes
testworkflow on pull requests, and on push only formain(same as mailtrap-ruby)lintcheck still matchesHow to test
testworkflow runs once andlintpassestestworkflow runs on the push tomaintestworkflow. A maintainer approves the first-time-contributor run,lintreports on Nodemailer 10 support #161, and it becomes mergeableImages and GIFs
N/A
Summary by CodeRabbit