Skip to content

run CI on pull requests - #162

Merged
oshchyhol merged 1 commit into
mainfrom
ci-run-on-pull-requests
Sep 29, 2026
Merged

oshchyhol merged 1 commit into
mainfrom
ci-run-on-pull-requests

Conversation

@oshchyhol

@oshchyhol oshchyhol commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor

Motivation

CI only runs on push. When a PR comes from a fork, the contributor pushes to their fork, so CI runs there and never reports checks on the PR here. lint is required on main, so a fork PR stays blocked even after it's approved. Example: #161 is approved, but lint is stuck on "Waiting for status to be reported".

Changes

  • run the test workflow on pull requests, and on push only for main (same as mailtrap-ruby)
  • job names stay the same, so the required lint check still matches
  • pushes to a branch with no PR no longer run CI. Internal PRs still run CI once, not twice

How to test

  • on this PR, the test workflow runs once and lint passes
  • after merge, the test workflow runs on the push to main
  • after merge, a new event on Nodemailer 10 support #161 (the contributor pushes or rebases, or a maintainer closes and reopens it) starts the test workflow. A maintainer approves the first-time-contributor run, lint reports on Nodemailer 10 support #161, and it becomes mergeable

Images and GIFs

N/A

Summary by CodeRabbit

  • Chores
    • Automated checks now run for pull requests and pushes to the main branch. They no longer run for pushes to every branch. This change affects the project’s development workflow and does not alter app functionality.

@coderabbitai

coderabbitai Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: a0891058-0796-46a2-bf78-68a03ef54e46

📥 Commits

Reviewing files that changed from the base of the PR and between e2685be and 035f5e6.

📒 Files selected for processing (1)
  • .github/workflows/test.yml

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.


📝 Walkthrough

Walkthrough

The test workflow now runs on pushes to main and on pull requests. Previously, it ran on pushes to any branch.

Changes

Test workflow triggers

Layer / File(s) Summary
Configure workflow triggers
.github/workflows/test.yml
The workflow runs on pushes to main and on pull requests.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 035f5

The requested CI triggers are configured, and the lint check remains intact; no actionable merge risk is identified.

Architecture Summary

Architecture risk: 🔵 Low · up to 035f5

The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency.

Changed systems: None identified.

Architecture concerns
No architecture-level concerns identified.

Review details

Before / after behavior

  • observed — Modified behavior in .github/workflows/test.yml: The workflow trigger changes from pushes on any branch to pushes on main, and adds pull requests as a trigger.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: running CI on pull requests.
Description check ✅ Passed The description includes the required Motivation, Changes, How to test, and Images and GIFs sections. It explains the fork pull request issue, the workflow changes, and the planned verification steps.…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@oshchyhol
oshchyhol marked this pull request as ready for review September 28, 2026 11:55
@oshchyhol
oshchyhol merged commit 6c5a0d7 into main Sep 29, 2026
4 checks passed
@oshchyhol
oshchyhol deleted the ci-run-on-pull-requests branch September 29, 2026 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants