feat: remove JS backed API's for attributes which are solely presentational - #36808
Open
Chris Holt (chrisdholt) wants to merge 25 commits into
Open
Chris Holt (chrisdholt) wants to merge 25 commits into
Chris Holt (chrisdholt) wants to merge 25 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Chris Holt (chrisdholt)
force-pushed
the
users/chhol/remove-js-api-for-presentational-attributes
branch
from
September 29, 2026 17:32
21ec2b3 to
0236d3f
Compare
📊 Bundle size report✅ No changes found |
|
Pull request demo site: URL |
Tudor Popa (tudorpopams)
approved these changes
Sep 29, 2026
| @@ -0,0 +1,6 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵🏾♀️ visual changes to review in the Visual Change Report
vr-tests-web-components/Avatar 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-web-components/Avatar. - Dark Mode.normal.chromium_1.png | 298 | Changed |
vr-tests-web-components/Badge 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-web-components/Badge. - Dark Mode.normal.chromium.png | 443 | Changed |
vr-tests-web-components/Divider 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-web-components/Divider.Inset.normal.chromium.png | 2 | Changed |
vr-tests-web-components/Label 2 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-web-components/Label. - Dark Mode.normal.chromium_1.png | 171 | Changed |
| vr-tests-web-components/Label.Disabled.normal.chromium.png | 116 | Changed |
vr-tests-web-components/Text 9 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| vr-tests-web-components/Text.Nowrap.normal.chromium.png | 6094 | Changed |
| vr-tests-web-components/Text.Strikethrough.normal.chromium.png | 209 | Changed |
| vr-tests-web-components/Text.Block.normal.chromium.png | 6296 | Changed |
| vr-tests-web-components/Text.Underline.normal.chromium.png | 265 | Changed |
| vr-tests-web-components/Text.Truncate.normal.chromium.png | 5819 | Changed |
| vr-tests-web-components/Text.Weight.normal.chromium.png | 12958 | Changed |
| vr-tests-web-components/Text.Italic.normal.chromium.png | 155 | Changed |
| vr-tests-web-components/Text.Font.normal.chromium.png | 6452 | Changed |
| vr-tests-web-components/Text.Size.normal.chromium.png | 70284 | Changed |
Dave Rupert (davatron5000)
approved these changes
Sep 29, 2026
Dave Rupert (davatron5000)
left a comment
Contributor
There was a problem hiding this comment.
🟥 🟥 🟥 🟥 ⬜ Love seeing all this red!
Left an optional comment on the Accordion Header changes but otherwise pretty straight forward.
Zacky Ma (marchbox)
approved these changes
Sep 29, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR converts CSS-only presentational attributes across Web Components from JavaScript fields to HTML-only attributes.
Benefits
Migration
Set presentational values using HTML attributes instead of JavaScript properties. Consumers who cannot apply attributes declaratively in HTML can still use JavaScript for attribute assignment via
setAttribute(),removeAttribute(), ortoggleAttribute().