[debug_counter] Add support for SAI_IN_DROP_REASON_LPM_ANY - #2354
Open
tsmail1441 wants to merge 1 commit into
Open
tsmail1441 wants to merge 1 commit into
tsmail1441 wants to merge 1 commit into
Conversation
Introduce SAI_IN_DROP_REASON_LPM_ANY to support ingress drop counting for L3 route lookup drops across various forwarding implementations and routing modes. Depending on hardware architecture and routing table configurations, unrouted or dropped L3 packets may not always trigger a native hardware lookup miss; they may instead be dropped by explicit route discard entries. Consequently, relying solely on SAI_IN_DROP_REASON_LPM_MISS can result in undercounting unrouted packets, while tracking broader L3 drop categories can conflate route resolution drops with unrelated forwarding drops. SAI_IN_DROP_REASON_LPM_ANY resolves this by providing a unified drop reason that captures packets dropped due to both LPM table misses and route discard actions. Changes: - Add SAI_IN_DROP_REASON_LPM_ANY enum to saidebugcounter.h. Change-Id: Ie11798439319cb29cf393a173afb1a2fede8ad19
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduce
SAI_IN_DROP_REASON_LPM_ANYto support ingress drop counting for both IPv4 and IPv6 L3 route lookup drops across various forwarding implementations and routing modes.Motivation
Depending on hardware architecture and routing table configurations, unrouted or dropped L3 packets may not always trigger a native hardware lookup miss; they may instead be dropped by explicit route discard entries. Consequently, relying solely on
SAI_IN_DROP_REASON_LPM_MISScan result in undercounting unrouted packets, while tracking broader L3 drop categories can conflate route resolution drops with unrelated forwarding drops.SAI_IN_DROP_REASON_LPM_ANYresolves this by providing a unified drop reason that captures both IPv4 and IPv6 packets dropped due to LPM table misses or explicit route discard actions, providing consistent drop accounting across both address families.Changes
SAI_IN_DROP_REASON_LPM_ANYenum toinc/saidebugcounter.h.Signed-off-by: Tommy Smail tommysmail@google.com