sql-statements: say that optimistic constraint checks are deferred until the transaction is committed - #24027
Conversation
…til the transaction is committed Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedNext included review available in 32 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository: pingcap/docs/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
[LGTM Timeline notifier]Timeline:
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiancai The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
In response to a cherrypick label: new pull request created to branch |
What is changed, added, or deleted? (Required)
In
sql-statements/sql-statement-commit.md, the MySQL compatibility section says that with optimistic locking,UNIQUEandPRIMARY KEYconstraint checks "are deferred until statement commit". The checks are deferred until the transaction commits, which is why theCOMMITstatement can fail. The same behavior is described that way elsewhere:constraints.md: "the unique check was deferred until the transaction is committed".transaction-overview.md: "These checks are instead performed on transactionCOMMIT".This PR changes "until statement commit" to "until the transaction is committed". It was flagged by CodeRabbit on the Japanese translation PR #24017, which inherited it from EN.
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
🤖 Generated with Claude Code