Skip to content

sql-statements: say that optimistic constraint checks are deferred until the transaction is committed - #24027

Merged
ti-chi-bot[bot] merged 1 commit into
pingcap:masterfrom
yahonda:fix-commit-deferred-constraint-check-wording
Sep 30, 2026
Merged

ti-chi-bot[bot] merged 1 commit into
pingcap:masterfrom
yahonda:fix-commit-deferred-constraint-check-wording

Conversation

@yahonda

@yahonda yahonda commented Sep 29, 2026

Copy link
Copy Markdown
Member

What is changed, added, or deleted? (Required)

In sql-statements/sql-statement-commit.md, the MySQL compatibility section says that with optimistic locking, UNIQUE and PRIMARY KEY constraint checks "are deferred until statement commit". The checks are deferred until the transaction commits, which is why the COMMIT statement can fail. The same behavior is described that way elsewhere:

  • constraints.md: "the unique check was deferred until the transaction is committed".
  • transaction-overview.md: "These checks are instead performed on transaction COMMIT".

This PR changes "until statement commit" to "until the transaction is committed". It was flagged by CodeRabbit on the Japanese translation PR #24017, which inherited it from EN.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)

What is the related PR or file link(s)?

AI agent involvement

  • The changes in this PR were primarily made by an AI agent on behalf of the PR author.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

🤖 Generated with Claude Code

…til the transaction is committed

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 29, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 32 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository: pingcap/docs/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: a0682d18-3b7c-4d60-bb83-7679f34bd185

📥 Commits

Reviewing files that changed from the base of the PR and between 2ea1beb and 2c52713.

📒 Files selected for processing (1)
  • sql-statements/sql-statement-commit.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 29, 2026
@qiancai qiancai added translation/doing This PR's assignee is translating this PR. and removed missing-translation-status This PR does not have translation status info. labels Sep 29, 2026

@qiancai qiancai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 30, 2026
@ti-chi-bot

ti-chi-bot Bot commented Sep 30, 2026

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2026-09-30 00:47:57.738972461 +0000 UTC m=+757002.964193568: ☑️ agreed by qiancai.

@qiancai qiancai added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Sep 30, 2026
@qiancai

qiancai commented Sep 30, 2026

Copy link
Copy Markdown
Collaborator

/approve

@qiancai qiancai added the lgtm label Sep 30, 2026
@ti-chi-bot

ti-chi-bot Bot commented Sep 30, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the approved label Sep 30, 2026
@ti-chi-bot
ti-chi-bot Bot merged commit 3e9907a into pingcap:master Sep 30, 2026
12 of 13 checks passed
@ti-chi-bot

Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #24064.

ti-chi-bot Bot pushed a commit that referenced this pull request Sep 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/doing This PR's assignee is translating this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants