Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Warning Review limit reachedNext included review available in 17 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Repository: pingcap/docs/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (15)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What is changed, added or deleted? (Required)
Fixes translation defects in 15 Japanese
tiup/docs, fromtiup-component-dm-scale-out.mdtotiup-troubleshooting-guide.mdin alphabetical order (chunk 03, the last chunk of the tiup review). Each site was checked against the EN source.Meaning fixes
tiup-mirror.md:jdoewith private key~/.tiup/keys/private.jsonownership of/data/mirror" was scrambled so thatjdoeread as the private key.--full,global-versionflags, and the component versions are not specified" merged two conditions and labeledglobal-versiona component version.tiup mirror clonewas inserted into "among hosts".tiup-mirror-reference.md: "a directory … serves the local TiUP client, which is called a local mirror" had "local mirror" attached to the client instead of the directory (×2 for local and remote).tiup-playground.md:Enterdirectly)" had become a condition ("if blank, press Enter").<kbd>wrapped キー instead of Enter.tiup-overview.md:tiup-terminology-and-concepts.md:tiup-component-dm.mdandtiup-reference.md:tiup-component-management.md:--tagsentence was garbled.trueor do not pass any value" sentence read as a prohibition. It is fixed indm-upgradeandtiup-component-dm(×3) with the same wording as i18n(ja): fix translation defects in tiup docs (command-completion to cluster-import) #24061 and i18n(ja): fix translation defects in tiup docs (cluster-list to dm-scale-in) #24062.Literal names restored
tiup-dm-topology-reference.md: YAML section names in link text (global,server_configs,master_servers,worker_servers,monitoring_servers,alertmanager_servers). The sibling itemgrafana_serversis already English.tiup-component-dm.md: the heading--ssh-timeout.tiup-overview.md: the component nameplayground.Other fixes
tiup-dm-topology-reference.md:deploy_dir/data_dir/log_dirrules and thexxx_serversintro sentences.dashboard_dirfield ofgrafana_servers" was garbled.tiup-troubleshooting-guide.md:tiup-component-dm-scale-out.md/tiup-component-dm.md:dm-upgradesummary.Not changed here:
tiup-component-dm-upgrade.mdis fixed in i18n(ja): fix unmatched full-width parentheses #23989.tiup-component-management.mdcome from EN, whose---all`` items have no space after the hyphen. That is an EN-side fix.EN-side candidates found here, not changed:
tiup-component-management.md:tiup-dm-topology-reference.md:log_dirdescribed as "the data directory"worker_servers"specifies the machines to which the master node … is deployed"tiup-terminology-and-concepts.mdL19 is self-contradictory.tiup-reference.mdL29 says "not printed" where "not installed" is likely meant.Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?
🤖 Generated with Claude Code