Unit tests: Expose native primitives in reduced-API builds - #1422
Open
hanno-becker wants to merge 1 commit into
Open
hanno-becker wants to merge 1 commit into
hanno-becker wants to merge 1 commit into
Conversation
hanno-becker
force-pushed
the
i1420
branch
2 times, most recently
from
September 9, 2026 14:17
35e9cb1 to
8146fca
Compare
Contributor
CBMC Results (ML-DSA-44, REDUCE-RAM)
Full Results (217 configurations)
|
Contributor
CBMC Results (ML-DSA-65, REDUCE-RAM)
Full Results (217 configurations)
|
Contributor
CBMC Results (ML-DSA-87, REDUCE-RAM)
Full Results (217 configurations)
|
Contributor
CBMC Results (ML-DSA-44)
Full Results (217 configurations)
|
Contributor
CBMC Results (ML-DSA-65)
Full Results (217 configurations)
|
Contributor
CBMC Results (ML-DSA-87)
Full Results (217 configurations)
|
Several backend unit tests were additionally guarded by the public APIs which use the tested primitives. Reduced-API builds therefore skipped available native implementations, while declarations and generated backend files used different guards. Make `MLD_UNIT_TEST` expose decomposition, hint use, `polyz` unpacking, and eta rejection sampling throughout the core and native backends. Simplify these tests, and the pointwise multiplication test, to depend only on their `MLD_USE_NATIVE_*` macros. Keep keypair-only eta helpers and `polyw1` packing under their original public API guards. Update autogen and the generated AArch64 and x86_64 files accordingly. Fixes #1420 Signed-off-by: Hanno Becker <beckphan@amazon.co.uk>
Contributor
Author
|
@mkannwischer This works, but the hierarchy of |
hanno-becker
marked this pull request as ready for review
September 13, 2026 06:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.