Conversation
Formatting 1.999999 seconds as ss.SSS returned 01.1000. The fraction rounded to the next second and was printed as four digits. Round the timestamp to the pattern's S width first so the second carries and the fraction stays within its width.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
format_timeandformat_datetimerounded a fractional second by printing an extra digit.time(0, 0, 1, 999999)with patternss.SSSreturned01.1000.The timestamp is now rounded to the pattern's
Swidth before the fields are formatted, so that second carries and the fraction stays the requested width (02.000). A pattern with noSfield is left alone, and a quotedSstays literal text.Test plan
time(0, 0, 1, 999999)formatted asss.SSSis02.000, andss.Sis02.0ssstays01, andss 'S'stays01 S23:59:59.999999formatted asHH:mm:ss.SSSrolls to00:00:00.0002020-01-01 23:59:59.999999formatted asyyyy-MM-dd HH:mm:ss.SSSrolls to2020-01-02 00:00:00.000time(0, 0, 1, 234600)formatted asss.SSSis01.235(the fraction rounds, the second does not carry)799microseconds asSSSSis0008,34567asSSSSis0346)