Skip to content

Arm backend: Fix grid_sample when Q/DQ have been fused by exir - #23255

Merged
gggekov merged 4 commits into
pytorch:mainfrom
gggekov:fix_grid_sample_exir_pass
Oct 2, 2026
Merged

Arm backend: Fix grid_sample when Q/DQ have been fused by exir#23255
gggekov merged 4 commits into
pytorch:mainfrom
gggekov:fix_grid_sample_exir_pass

Conversation

@gggekov

@gggekov gggekov commented Sep 29, 2026 •
edited by pytorch-bot Bot
Loading

Copy link
Copy Markdown
Collaborator

#22905 removes some Q/DQ nodes before running the Arm passes. In the FuseGridSamplerFlowOffsetPass pass, we expected to have a Q/DQ pair before the grid_sample, but that pair is now removed at the time of running the exir passes.
Change the guard in FuseGridSamplerFlowOffsetPass to check for concat before the grid_sample to account for the fact we now have a cat.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell @rascani

@pytorch-bot

pytorch-bot Bot commented Sep 29, 2026 •
edited
Loading

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/23255

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 4a62a4b with merge base 89809c4 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions github-actions Bot added ciflow/trunk module: arm Issues related to arm backend labels Sep 29, 2026
@github-actions

github-actions Bot commented Sep 29, 2026

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 29, 2026
@gggekov
Arm backend: Fix grid_sample when Q/DQ have been fused by exir
3d11077 
pytorch#22905 removes
some Q/DQ nodes before running the Arm passes. In the
FuseGridSamplerFlowOffsetPass pass, we expected to have a
Q/DQ pair before the grid_sample, but that pair is now removed
at the time of running the exir passes.
Change the guard in FuseGridSamplerFlowOffsetPass to check for
concat before the grid_sample to account for the fact we now
have a cat.

Signed-off-by: George Gekov <george.gekov@arm.com>
Change-Id: Icd968d84c6ec499626ddf5839a5728afbb00a731
@gggekov
gggekov force-pushed the fix_grid_sample_exir_pass branch from 58011a0 to 3d11077 Compare October 1, 2026 10:36
@zingo

zingo commented Oct 2, 2026

Copy link
Copy Markdown
Collaborator

Double check buck2 changes before merging.

@gggekov
gggekov merged commit 64c13a2 into pytorch:main Oct 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zingo zingo zingo approved these changes
@Sebastian-Larsson Sebastian-Larsson Sebastian-Larsson approved these changes
@digantdesai digantdesai Awaiting requested review from digantdesai digantdesai is a code owner

Assignees

No one assigned

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: arm Issues related to arm backend

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gggekov @zingo @Sebastian-Larsson