NXP backend: use channels-first for reference testing model - #23308
Open
novak-vaclav wants to merge 1 commit into
Open
novak-vaclav wants to merge 1 commit into
novak-vaclav wants to merge 1 commit into
Conversation
novak-vaclav
requested review from
robert-kalmar and
roman-janik-nxp
and
a balanced review from Copilot
October 1, 2026 12:24
novak-vaclav
added
module: nxp
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/23308
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit b175439 with merge base bdb7964 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
|
novak-vaclav
changed the title
novak-vaclav
force-pushed
the
feature/EIEX-1086-refactor-reference-testing
branch
from
October 2, 2026 07:01
4ab988d to
fac119b
Compare
novak-vaclav
force-pushed
the
feature/EIEX-1086-refactor-reference-testing
branch
from
October 2, 2026 09:34
fac119b to
50d2130
Compare
novak-vaclav
force-pushed
the
feature/EIEX-1086-refactor-reference-testing
branch
from
October 2, 2026 09:38
50d2130 to
c77215a
Compare
Collaborator
Author
|
(Hopefully) fixed all issues with failing tests |
novak-vaclav
force-pushed
the
feature/EIEX-1086-refactor-reference-testing
branch
from
October 2, 2026 16:33
c77215a to
b175439
Compare
Contributor
|
cc @SS-JIA |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactor the testing suite to enable reference testing in channels-first.
Note: currently the test bounds are set to
np.inf. Their value will be subject to change after #23274 PR is merged.Test plan
tests can be manually run using
pytest -c /dev/null backends/nxp/tests/cc @robert-kalmar @JakeStevens @digantdesai @rascani @roman-janik-nxp