Skip to content

ci: disable late multimodal test on mac - #738

Merged
joein merged 2 commits into
mainfrom
skip-late-multimodal-test-on-macos
Sep 26, 2026
Merged

joein merged 2 commits into
mainfrom
skip-late-multimodal-test-on-macos

Conversation

@joein

@joein joein commented Sep 26, 2026

Copy link
Copy Markdown
Member

No description provided.

@coderabbitai

coderabbitai Bot commented Sep 26, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: bb4ffad2-cc17-4a1f-94d3-08b6c363284b

📥 Commits

Reviewing files that changed from the base of the PR and between 3490f69 and 9a6114c.

📒 Files selected for processing (2)
  • .github/workflows/python-tests.yml
  • tests/test_late_interaction_multimodal.py

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 6 remain after this review.


📝 Walkthrough

Walkthrough

The Python test workflow adds --durations=10 on macOS runners. Two image embedding tests now skip on Darwin when CI is set. The tests continue to run in other environments.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 9a611

The change limits two slow image checks to non-macOS CI runs without disabling the macOS workflow. The checks still run on Ubuntu and Windows, so no material merge risk is evident.

🚥 Pre-merge checks | ✅ 3 | ❌ 1 | ❓ 1

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files. (1 skipped: 1 … Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive No pull request description was provided, so the relationship between the changes and their purpose cannot be assessed from the description. Add a short description that explains the macOS CI test skip and the pytest duration reporting change.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: disabling the late multimodal test on macOS CI.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files. (1 skipped: 1 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@joein
joein merged commit ff699e8 into main Sep 26, 2026
17 checks passed
@joein
joein deleted the skip-late-multimodal-test-on-macos branch September 26, 2026 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant