Conversation
- Wrap FileWriter with BufferedWriter in writeFile() to reduce unbuffered OS write calls - Cache JAXBContext as a static final field, replacing per-call JAXBContext.newInstance() in both generate(Repository,File) and unmarshal() - Cache compiled XPathExpression as a static final field (REQUIRED_GROUP_REF_XPATH), replacing per-call XPathFactory/XPath/compile() in getRequiredGroups()
Copilot
AI
changed the title
perf: improve DataDictionaryGenerator performance by caching JAXBContext, XPath expression, and buffering file output
perf: DataDictionaryGenerator — buffer output, cache JAXBContext and XPathExpression
Jul 17, 2026
Copilot created this pull request from a session on behalf of
chrjohn
July 17, 2026 13:43
View session
… duplication Extract the repeated char[]-fill-new String(...) pattern into a private static buildIndent(int level) method, used by both the INDENTS static initializer and the indent() fallback path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DataDictionaryGeneratorrepeated three expensive operations on every generation run: unbuffered file I/O,JAXBContext.newInstance()(classpath scan + reflection), andXPathFactory/XPath/compile()setup. None of these need to happen more than once.Changes
FileWriterinBufferedWriterinsidewriteFile(), batching OS write calls (mirrors existingCodeGeneratorJpattern)JAXBContext— introducestatic final JAXB_CONTEXT, eliminating two per-callJAXBContext.newInstance()invocations ingenerate(Repository, File)andunmarshal()XPathExpression— introducestatic final REQUIRED_GROUP_REF_XPATH, compiling//fixr:groupRef[@presence='required']and its namespace context once at class load instead of on everygetRequiredGroups()call