Skip to content

[RAPPS-DB] Move Notepad++ from Office to Development category - #407

Merged
learn-more merged 1 commit into
reactos:masterfrom
jeditobe:patch-7
Sep 9, 2026
Merged

learn-more merged 1 commit into
reactos:masterfrom
jeditobe:patch-7

Conversation

@jeditobe

@jeditobe jeditobe commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Notepad++ is obviously not an office app! Six-seven!

Notepad++ is obviously not an office app! Six-seven!
@binarymaster binarymaster changed the title Update npp.txt fix wrong category [RAPPS-DB] Move Notepad++ from Office to Development category Sep 4, 2026
@binarymaster binarymaster added the enhancement New feature or request label Sep 4, 2026
@whindsaks

Copy link
Copy Markdown
Contributor

Or is the generic tool category a better fit? Sysadmins etc. will edit configuration files.

@HBelusca HBelusca left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It technically depends for what purposes someone used npp.

@HBelusca

HBelusca commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Side thought: I wonder whether we support showing a given app in more than one single category.

@whindsaks

Copy link
Copy Markdown
Contributor

I wonder whether we support showing a given app in more than one single category

We don't. If we are lucky, the current version will be able to parse 1|7 as 1 without errors, then there is a chance.

@jeditobe

jeditobe commented Sep 5, 2026

Copy link
Copy Markdown
Contributor Author

Notepad++ should be in the same category as Notepad2e, that is the idea

@learn-more
learn-more merged commit 0eb5dbf into reactos:master Sep 9, 2026
1 check passed
@whindsaks

Copy link
Copy Markdown
Contributor

If we are lucky, the current version will be able to parse 1|7 as 1 without errors

And we are lucky, current RAPPS uses CConfigParser::GetInt and that just calls StrToIntW which just stops parsing after the first non-numeric character without errors. So we can extend this in the future to support multiple categories per package...

@whindsaks

Copy link
Copy Markdown
Contributor

in the future to support multiple categories per package

RappsAppMultiCat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants