Inherit allow_zero_lintable_files from parent config - #6895
Closed
shubhransh-gupta wants to merge 1 commit into
Closed
shubhransh-gupta wants to merge 1 commit into
shubhransh-gupta wants to merge 1 commit into
Conversation
Generated by 🚫 Danger |
Collaborator
|
Did you check the history of #6240? The issue thread, open PR, comments, ...? The implementation requires more than what you and others proposed and requires careful consideration. |
Author
|
Thanks for pointing that out, @SimplyDanny. I reviewed the history across #6240, #5724, and the open draft in #6874. You're completely right:
Closing this PR in favor of #6874. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #6240.
When merging a parent configuration with a child configuration via
parent_config,Configuration+Merging.swiftwas takingchildConfiguration.allowZeroLintableFiles. Becauseallow_zero_lintable_filesdefaults tofalsewhen unspecified in the child config dictionary, the child config was inadvertently overriding and discardingallow_zero_lintable_files: truedefined in the parent config.Changes
Configuration+Merging.swift, mergeallowZeroLintableFilesusingchildConfiguration.allowZeroLintableFiles || allowZeroLintableFiles.allowZeroLintableFilesMerginginTests/FileSystemAccessTests/ConfigurationTests.swift.CHANGELOG.mdentry underBug Fixesfollowing repository guidelines.