Skip to content

Remove megapool address from validator proof - #1237

Merged
0xfornax merged 1 commit into
masterfrom
remove-mp-address
Sep 25, 2026
Merged

0xfornax merged 1 commit into
masterfrom
remove-mp-address

Conversation

@0xfornax

Copy link
Copy Markdown
Member

No description provided.

@0xfornax
0xfornax merged commit ba1b479 into master Sep 25, 2026
3 of 5 checks passed
@github-actions

Copy link
Copy Markdown

Coverage Report

@github-actions

Copy link
Copy Markdown

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/rocket-pool/smartnode/rocketpool/api/megapool 0.07% (ø)
github.com/rocket-pool/smartnode/rocketpool/node 0.34% (ø)
github.com/rocket-pool/smartnode/rocketpool/watchtower 0.65% (ø)
github.com/rocket-pool/smartnode/shared/services 0.53% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/rocket-pool/smartnode/rocketpool/api/megapool/challenge-performance.go 0.00% (ø) 3338 0 3338
github.com/rocket-pool/smartnode/rocketpool/api/megapool/dissolve-with-proof.go 0.00% (ø) 3669 0 3669
github.com/rocket-pool/smartnode/rocketpool/api/megapool/notify-validator-exit.go 0.00% (ø) 4507 0 4507
github.com/rocket-pool/smartnode/rocketpool/api/megapool/stake.go 0.00% (ø) 3727 0 3727
github.com/rocket-pool/smartnode/rocketpool/node/check-minipool-exit-requests.go 0.00% (ø) 6910 0 6910
github.com/rocket-pool/smartnode/rocketpool/node/defend-challenge-exit.go 0.00% (ø) 3443 0 3443
github.com/rocket-pool/smartnode/rocketpool/node/defend-challenge-performance.go 0.11% (ø) 7255 8 7247
github.com/rocket-pool/smartnode/rocketpool/node/notify-validator-exit.go 0.00% (ø) 4293 0 4293
github.com/rocket-pool/smartnode/rocketpool/node/stake-megapool-validator.go 0.00% (ø) 3905 0 3905
github.com/rocket-pool/smartnode/rocketpool/watchtower/dissolve-invalid-credentials.go 0.00% (ø) 2945 0 2945
github.com/rocket-pool/smartnode/shared/services/megapools.go 0.80% (ø) 29114 234 28880

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant