Implement cromulent Copy closure captures

[Jules-Bertholet]

View all comments

Implements rust-lang/rfcs#4011.

@rustbot label T-lang A-closures needs-fcp

[clarfonthey]

@bors try
@rust-timer queue

[clarfonthey]

@bors try

[Jules-Bertholet]

@clarfonthey fyi, there was no need to restart the build, I only made a change to rust-analyzer. (And might make some more)

[clarfonthey]

Yeah, my bad, I misread what had actually happened. Didn't lose a lot of time at least.

[rust-bors]

☀️ Try build successful (CI)
Build commit: 5692858 (5692858f685c960610bef733616eeec75920fa40)
Base parent: db23a2d (db23a2d392783030c008a5fafbe6cb139d1f7707)

[rust-timer]

Finished benchmarking commit (5692858): comparison URL.

Overall result: ❌✅ regressions and improvements - please read:

Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf.

Next, please: If you can, justify the regressions found in this try perf run in writing along with @rustbot label: +perf-regression-triaged. If not, fix the regressions and do another perf run. Neutral or positive results will clear the label automatically.

@bors rollup=never rustc-perf
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	1.0%	[0.3%, 1.7%]	2
Regressions ❌ (secondary)	0.9%	[0.0%, 1.6%]	12
Improvements ✅ (primary)	-0.7%	[-5.0%, -0.2%]	261
Improvements ✅ (secondary)	-0.8%	[-6.8%, -0.1%]	214
All ❌✅ (primary)	-0.6%	[-5.0%, 1.7%]	263

Max RSS (memory usage)

Results (primary -2.0%, secondary -1.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	3.0%	[2.4%, 3.6%]	2
Regressions ❌ (secondary)	3.2%	[2.1%, 4.2%]	2
Improvements ✅ (primary)	-2.7%	[-6.3%, -0.8%]	15
Improvements ✅ (secondary)	-3.2%	[-6.0%, -0.5%]	7
All ❌✅ (primary)	-2.0%	[-6.3%, 3.6%]	17

Cycles

Results (primary -2.2%, secondary -4.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	3.4%	[2.1%, 4.6%]	2
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-3.2%	[-5.6%, -1.3%]	11
Improvements ✅ (secondary)	-4.7%	[-6.6%, -3.8%]	8
All ❌✅ (primary)	-2.2%	[-5.6%, 4.6%]	13

Binary size

Results (primary 0.1%, secondary -0.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.4%	[0.1%, 1.1%]	19
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.3%	[-0.9%, -0.0%]	17
Improvements ✅ (secondary)	-0.3%	[-0.5%, -0.0%]	13
All ❌✅ (primary)	0.1%	[-0.9%, 1.1%]	36

Bootstrap: 489.541s -> 492.774s (0.66%)
Artifact size: 408.63 MiB -> 408.96 MiB (0.08%)