fix(ci): make the PyPI publish workflow actually runnable - #537
Merged
Merged
Conversation
Three things independently prevented a release: - Both jobs were gated on `github.repository_owner == 'twilio'`, carried over from the reference implementation. This repo is under segmentio, so a published release skipped both jobs and reported success having uploaded nothing. The guard still blocks forks, just against the right owner. - The runner expression fell through to bare ubuntu-latest, which gets no runner in this org. - Tag validation required a v prefix; every tag here is bare (2.3.6, 2.3.5). Both forms are accepted now. RELEASING.md described a local twine upload and a bare tag push. Neither reaches the OIDC path, and `release: published` does not fire on a tag push at all, so it now says to cut a GitHub Release and to bump pyproject.toml — which is the file the tag is validated against.
wenxi-zeng
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The publish workflow has never run. Three independent blockers, each of which alone prevents a release:
if: github.repository_owner == 'twilio'on both jobsruns-onfalls through to bareubuntu-latestvprefix2.3.6,2.3.5, …)The first two came from the
twilio-agent-connect-typescriptreference implementation, where the owner guard is correct.The fork guard is kept, just pointed at the right owner.
RELEASING.mdwas also stale in a way that matters: it told you to runmake release(a localtwine uploadthat bypasses Trusted Publishing and provenance) and to publish by pushing a tag.on: release: [published]does not fire on a tag push — it needs a GitHub Release. It also omittedpyproject.toml, which is the file the workflow validates the tag against, so following it produced a version mismatch.Not addressed here:
make releasestill exists as a break-glass path, and the version lives in bothpyproject.tomlandsegment/analytics/version.py.