Conversation
When a verse range started with a verse that was already written, the whole range marker was dropped, merging later verses into the previous one. Now only the duplicated verse is suppressed and the rest of the range is still written. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #521 +/- ##
==========================================
+ Coverage 74.09% 74.11% +0.01%
==========================================
Files 456 456
Lines 38107 38119 +12
Branches 5221 5226 +5
==========================================
+ Hits 28237 28250 +13
Misses 8712 8712
+ Partials 1158 1157 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Preserved trailing paragraph markers collected before a verse that is not kept were flushed at the next kept verse, producing stray empty paragraphs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ddaspit
left a comment
There was a problem hiding this comment.
I pushed two fixes.
@ddaspit reviewed 2 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on Enkidu93 and pmachapman).
tests/SIL.Machine.Tests/Corpora/ConvertUsfmVersificationHandlerTests.cs line 977 at r3 (raw file):
string[] targetLines = target.Split('\n'); string[] truthLines = truth.Split('\n'); // Assert.That(targetLines.Length, Is.EqualTo(truthLines.Length));
Nit: did you mean to comment this out?
pmachapman
left a comment
There was a problem hiding this comment.
This worked well for my test projects.
@pmachapman reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on Enkidu93).
Fixes #517, #518.
This change is