fix(socket-mode): handle Events API payloads without inner events - #2754
Draft
kyungyeon-byun-imweb-me wants to merge 1 commit into
Draft
kyungyeon-byun-imweb-me wants to merge 1 commit into
kyungyeon-byun-imweb-me wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 4f1ff57 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Thanks for the contribution! Before we can merge this, we need @kyungyeon-byun-imweb-me to sign the Salesforce Inc. Contributor License Agreement. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2753.
SocketModeClientcurrently assumes everyevents_apipayload containspayload.event.type. Slack's documentedapp_rate_limitedpayload has its event type at the top level and no innerevent, so that assumption throws before consumers can acknowledge the envelope.This change:
app_rate_limited;slack_eventemission and ACK function;app_rate_limited, malformed payloads, and invalid inner-event type fallback;@slack/socket-mode.Validation completed:
npm run build --workspace=@slack/loggernpm run build --workspace=@slack/typesnpm run build --workspace=@slack/web-apinpm run build --workspace=@slack/socket-modenpm test --workspace=@slack/socket-mode(43 passing)npm run lintRequirements