Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 SummarySummary by CodeRabbit
WalkthroughThe web ChangesScrollView gesture wrapper
Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to The web ScrollView now uses the intended intercepting gesture detector, with no concrete current-head failure established. 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🟢 Approval recommended
The change matches native behavior and has no unresolved review comments.
Pull request overview
Updates the web ScrollView to use intercepting gesture-detector behavior, matching native platforms.
Changes:
- Applies
GestureDetectorType.Interceptingto the webScrollView.
File summaries
| File | Description |
|---|---|
packages/react-native-gesture-handler/src/v3/components/GestureComponents.web.tsx |
Makes the web ScrollView an intercepting detector. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Description
On Android and iOS the
ScrollViewwrappers are created withGestureDetectorType.Intercepting, so aVirtualGestureDetectorrendered inside them has an intercepting ancestor. The web wrappers were created with the default detector type, so the same code throwsThis PR passes
GestureDetectorType.Interceptingto the webScrollViewTest plan
Checked ScrollView example