Remove _id suffix from BatchEdit changed -to-ones in the Audit Log - #8561
Draft
g1rly-c0d3r wants to merge 1 commit into
Draft
g1rly-c0d3r wants to merge 1 commit into
g1rly-c0d3r wants to merge 1 commit into
Conversation
…if they were edited through forms
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8555
The backend has two different names for to-one relationships, an
attnamefor the ID, as in how the underlying database identifies relationships, and aname, which is used to link to the actual relationship record.On a form, when the to-one relationship is changed, we send the
namefield to the audit log. Before, BatchEdit would send theattnameto the audit log, which just adds the_idsuffix to thename. Now, BatchEdit sends thenamefield, in line with how a change through the forms would be logged.main:issue-8555(this pr):Checklist
self-explanatory (or properly documented)
Testing instructions