Conversation
Closes spring-projectsgh-37359 Signed-off-by: Mahammad Eminov <64434582+Emin0v@users.noreply.github.com>
spring-projects-issues
added
the
status: waiting-for-triage
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the connection leak reported in #37359.
When a connection is explicitly released inside a reactive transaction,
ConnectionHolder.released()clearscurrentConnectiononce the reference count reaches zero. The transaction synchronization then has no connection left to close during cleanup.The change keeps the connection in the holder while it is synchronized with a transaction. The release behavior for other holders remains unchanged.
I added two regression tests covering connection reuse within the same transaction and release before transaction suspension. Both tests fail on the original code and pass with this fix.
The
spring-r2dbctests and Checkstyle checks pass.Closes gh-37359