Skip to content

refactor: Flatten role configs - #867

Open
adwk67 wants to merge 5 commits into
mainfrom
refactor/flatten-config-maps
Open

adwk67 wants to merge 5 commits into
mainfrom
refactor/flatten-config-maps

Conversation

@adwk67

@adwk67 adwk67 commented Sep 23, 2026 •

Copy link
Copy Markdown
Member

Description

Part of https://github.com/stackabletech/internal-issues/issues/167.

--- PASS: kuttl (3269.67s)
    --- PASS: kuttl/harness (0.00s)
        --- PASS: kuttl/harness/mount-dags-gitsync_airflow-latest-3.3.1_openshift-false_executor-celery_access-https (713.18s)
        --- PASS: kuttl/harness/versioning_airflow-latest-3.3.1_openshift-false (849.34s)
        --- PASS: kuttl/harness/smoke_airflow-3.3.1_openshift-false_executor-kubernetes (211.49s)
        --- PASS: kuttl/harness/opa_airflow-3.3.1_opa-latest-1.16.2_openshift-false (239.54s)
        --- PASS: kuttl/harness/smoke_airflow-3.3.1_openshift-false_executor-celery (387.11s)
        --- PASS: kuttl/harness/mount-dags-configmap_airflow-latest-3.3.1_openshift-false_executor-kubernetes (274.97s)
        --- PASS: kuttl/harness/mount-dags-configmap_airflow-latest-3.3.1_openshift-false_executor-celery (232.50s)
        --- PASS: kuttl/harness/remote-logging_airflow-latest-3.3.1_openshift-false_executor-kubernetes (258.97s)
        --- PASS: kuttl/harness/remote-logging_airflow-latest-3.3.1_openshift-false_executor-celery (279.91s)
        --- PASS: kuttl/harness/logging_airflow-3.3.1_openshift-false_executor-celery (352.69s)
        --- PASS: kuttl/harness/overrides_airflow-latest-3.3.1_openshift-false (180.55s)
        --- PASS: kuttl/harness/logging_airflow-3.3.1_openshift-false_executor-kubernetes (713.32s)
        --- PASS: kuttl/harness/resources_airflow-latest-3.3.1_openshift-false (158.63s)
        --- PASS: kuttl/harness/ca-cert_airflow-latest-3.3.1_openshift-false (171.96s)
        --- PASS: kuttl/harness/mount-dags-gitsync_airflow-latest-3.3.1_openshift-false_executor-kubernetes_access-https (278.85s)
        --- PASS: kuttl/harness/opa-interop_airflow-latest-3.3.1_opa-latest-1.16.2_openshift-false (134.48s)
        --- PASS: kuttl/harness/mount-dags-gitsync_airflow-latest-3.3.1_openshift-false_executor-kubernetes_access-ssh (272.32s)
        --- PASS: kuttl/harness/cluster-operation_airflow-latest-3.3.1_openshift-false (334.28s)
        --- PASS: kuttl/harness/mount-dags-gitsync_airflow-latest-3.3.1_openshift-false_executor-celery_access-ssh (415.59s)
PASS

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • (Integration-)Test cases added
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@adwk67 adwk67 self-assigned this Sep 24, 2026
@adwk67
adwk67 marked this pull request as ready for review September 24, 2026 07:06
@siegfriedweber
siegfriedweber self-requested a review October 6, 2026 09:55
Comment on lines +151 to +153
group_listener_name: airflow
.group_listener_name(&AirflowRole::Webserver)
.expect("the webserver role always has a group listener"),

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

group_listener_name() could be renamed to webserver_role_group_listener_name() and return ListenerName instead of Option<ListenerName>.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adwk67
adwk67 requested a review from siegfriedweber October 6, 2026 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants