chore: remove unused modules after migration to Jakarta - #5316
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Release scripts still target the deleted Jakarta module, and documentation still references removed Jakarta artifacts.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
This chore removes obsolete Jakarta transformation modules, the custom Eclipse Transformer plugin, and the deprecated servlet initializer while simplifying Maven and BOM configuration.
Changes:
- Deletes obsolete Jakarta modules and transformer-related files.
- Removes legacy servlet initializer configuration.
- Cleans reactor, plugin, BOM, and integration-test settings.
File summaries
| File | Reviewed change |
|---|---|
pom.xml |
Removes obsolete reactor modules and transformer properties. Critical (2 votes): Release scripts still change into the deleted Jakarta directory and must be updated. |
modules/swagger-project-jakarta/pom.xml |
Deletes the Jakarta parent project. Critical (1 vote): Release scripts still target this deleted directory. Nit (1 vote): Documentation still references removed Jakarta artifacts. |
modules/swagger-project-jakarta/modules/swagger-models-jakarta/pom.xml |
Deletes the transformed models module. |
modules/swagger-project-jakarta/modules/swagger-maven-plugin-jakarta/transformed/README.md |
Deletes the transformed plugin output marker. |
modules/swagger-project-jakarta/modules/swagger-maven-plugin-jakarta/src/main/java/io/swagger/v3/plugin/maven/jakarta/JakartaTransformer.java |
Deletes the Jakarta transformer implementation. |
modules/swagger-project-jakarta/modules/swagger-maven-plugin-jakarta/pom.xml |
Deletes the transformed Maven plugin module. |
modules/swagger-project-jakarta/modules/swagger-jaxrs2-servlet-initializer-v2-jakarta/pom.xml |
Deletes the transformed initializer module. |
modules/swagger-project-jakarta/modules/swagger-jaxrs2-servlet-initializer-jakarta/pom.xml |
Deletes the transformed initializer module. |
modules/swagger-project-jakarta/modules/swagger-jaxrs2-jakarta/pom.xml |
Deletes the transformed JAX-RS module. |
modules/swagger-project-jakarta/modules/swagger-integration-jakarta/pom.xml |
Deletes the transformed integration module. |
modules/swagger-project-jakarta/modules/swagger-core-jakarta/pom.xml |
Deletes the transformed core module. |
modules/swagger-project-jakarta/modules/swagger-annotations-jakarta/pom.xml |
Deletes the transformed annotations module. |
modules/swagger-project-jakarta/.gitignore |
Removes obsolete ignore rules. |
modules/swagger-maven-plugin/pom.xml |
Removes custom Jakarta transformation execution. |
modules/swagger-jaxrs2-servlet-initializer/src/main/resources/META-INF/services/javax.servlet.ServletContainerInitializer |
Removes the legacy service registration. |
modules/swagger-jaxrs2-servlet-initializer/src/main/java/io/swagger/v3/jaxrs2/integration/SwaggerServletInitializer.java |
Deletes the legacy initializer implementation. |
modules/swagger-jaxrs2-servlet-initializer/pom.xml |
Deletes the deprecated initializer module configuration. |
modules/swagger-eclipse-transformer-maven-plugin/src/main/java/io/swagger/v3/oas/transformer/TransformMojo.java |
Deletes the custom transformer implementation. |
modules/swagger-eclipse-transformer-maven-plugin/README.md |
Deletes obsolete plugin documentation. |
modules/swagger-eclipse-transformer-maven-plugin/pom.xml |
Deletes the transformer plugin configuration. |
modules/swagger-bom/pom.xml |
Removes obsolete artifact management. Nit (2 votes): Update documentation that still describes and references removed Jakarta artifacts. |
modules/swagger-bom-integration-test/pom.xml |
Removes deleted dependencies and the obsolete enforcer configuration. |
Review details
Suppressed comments (2)
modules/swagger-project-jakarta/pom.xml:1
- Removing this module leaves
CI/prepare-release.shandCI/post-release.shstill executingcd modules/swagger-project-jakarta. Those directories no longer exist, so release versioning continues with failed path changes (and the following../../mvnwcommands run from the wrong directory). Remove or update those release-script steps in the same change.
modules/swagger-project-jakarta/pom.xml:1 - This deletion removes the Jakarta artifacts and the transformer-generated
swagger-maven-plugin-jakarta, butREADME.mdstill says the BOM manages both artifact families and lists the removed dependencies, whilemodules/swagger-maven-plugin/README.mdstill instructs users to use the Jakarta plugin. Those examples will no longer resolve for this project version; update the published documentation together with the artifact removal.
- Files reviewed: 22/22 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…umentation for Jakarta transition
ewaostrowska
approved these changes
Sep 15, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Thank you for contributing to swagger-core!
Please fill out the following information to help us review your PR efficiently.
Description
This pull request removes the custom
swagger-eclipse-transformer-maven-pluginmodule and all its related files from the project. Additionally, it cleans up dependencies and plugin configurations related to Jakarta artifacts and the transformer plugin in the BOM and integration test modules.Key changes include:
Removal of the custom Maven plugin
swagger-eclipse-transformer-maven-pluginmodule, including itspom.xml,README.md, and main Java source fileTransformMojo.java. This means the project no longer maintains a custom Eclipse Transformer Maven plugin.Dependency and plugin cleanup
swagger-jaxrs2-servlet-initializerdependency from the BOM (swagger-bom/pom.xml) and its integration test (swagger-bom-integration-test/pom.xml). This reduces the number of managed and tested artifacts and simplifies dependency management.Minor cleanup
Follow-up: #4991
Type of Change
Checklist
Screenshots / Additional Context