-
Notifications
You must be signed in to change notification settings - Fork 26
phpDocumentor Guides integration #200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
wouterj
wants to merge
35
commits into
symfony-tools:main
Choose a base branch
from
wouterj:phpdocumentor-guides
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
f4840e0
Convert docs builder into an extension
wouterj 393b005
Cleanup
wouterj bbf362b
Update to latest Guides
wouterj 18d2a46
Upgrade to latest guides and use guides-code's highlighter
wouterj 6b5d24e
Fix SymfonyExtension build
wouterj 8ff0432
Set-up Psalm CI
wouterj 9bb899f
Set-up PHP CS Fixer CI
wouterj 6c3f116
Use guides-code from Packagist
wouterj 97f1bcf
Upgrade to Sphinx RTD Theme 2.0.0
wouterj 1640b05
Unskip fixed test cases
wouterj d0adf5c
Upgrade Guides and split RTD theme
wouterj 2392db4
Do not use anchors for document links in toctree
wouterj 06ebd83
Enable toctree project test
wouterj a502e4d
Fix CI
wouterj cffbca8
Fix CS
wouterj 7f8eef1
Upgrade to Guides 1.0
wouterj 8456f7b
Made last skipped test green
wouterj 54ecae2
Upgrade to latest Guides
wouterj cf12d4a
Upgrade other dependencies
wouterj 043daa4
Apply recent changes to DocsBuilder in new code
wouterj 19fdbfc
Move GuidesExtension code into a subdirectory
wouterj d632030
Merge integration tests
wouterj 858e20c
Replace version placeholder with Symfony version in URLs
wouterj a65752a
Use newer PHPUnit version in GitHub Workflow
wouterj 10c99fd
Fix php class role with namespaced FQCN
wouterj 2b6f54e
Skip non-html integration tests
wouterj 4d25f93
Update caution icon
wouterj 482a4c3
Fix highlightphp tests
wouterj 5bcc31f
Add fjson renderer
wouterj 73915c8
Upgrade to Symfony 8
wouterj 75de379
Add support for tabs directive
wouterj 6a28d55
Require PHPUnit directly
wouterj 0926146
Upgrade Guides to fix the `testBlocks@nodes/title.rst` test
wouterj fc970ed
Update JsonRenderer tests based on real integration
wouterj 1971453
Use relative references
wouterj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,11 @@ | ||
| !tools/*/composer.lock | ||
| /vendor/ | ||
| /tests/_output | ||
| /tests/_cache | ||
| /var/ | ||
| /docs.phar | ||
| /.env | ||
| /.php-cs-fixer.cache | ||
| /.phpunit.result.cache | ||
| /.phpunit.cache | ||
| /composer.lock |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| <?php | ||
|
|
||
| $fileHeaderComment = <<<EOT | ||
| This file is part of the Guides SymfonyExtension package. | ||
|
|
||
| (c) Wouter de Jong | ||
|
|
||
| For the full copyright and license information, please view the LICENSE | ||
| file that was distributed with this source code. | ||
| EOT; | ||
|
|
||
| return (new PhpCsFixer\Config()) | ||
| ->setRules([ | ||
| '@PHP71Migration' => true, | ||
| '@PHPUnit75Migration:risky' => true, | ||
| '@Symfony' => true, | ||
| '@Symfony:risky' => true, | ||
| 'protected_to_private' => false, | ||
| 'native_constant_invocation' => ['strict' => false], | ||
| 'no_superfluous_phpdoc_tags' => [ | ||
| 'remove_inheritdoc' => true, | ||
| 'allow_unused_params' => true, // for future-ready params, to be replaced with https://github.com/PHP-CS-Fixer/PHP-CS-Fixer/issues/7377 | ||
| ], | ||
| 'header_comment' => ['header' => $fileHeaderComment], | ||
| 'modernize_strpos' => true, | ||
| 'get_class_to_class_keyword' => true, | ||
| 'nullable_type_declaration' => true, | ||
| ]) | ||
| ->setRiskyAllowed(true) | ||
| ->setFinder( | ||
| (new PhpCsFixer\Finder()) | ||
| ->in(__DIR__.'/src') | ||
| ) | ||
| ; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
| xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/12.4/phpunit.xsd" | ||
| bootstrap="vendor/autoload.php" | ||
| beStrictAboutOutputDuringTests="true" | ||
| failOnDeprecation="true" | ||
| failOnRisky="true" | ||
| failOnWarning="true" | ||
| cacheDirectory=".phpunit.cache" | ||
| beStrictAboutCoverageMetadata="true"> | ||
| <testsuites> | ||
| <testsuite name="default"> | ||
| <directory>tests</directory> | ||
| </testsuite> | ||
| </testsuites> | ||
|
|
||
| <source ignoreSuppressionOfDeprecations="true" | ||
| ignoreIndirectDeprecations="true" | ||
| restrictNotices="true" | ||
| restrictWarnings="true"> | ||
| <include> | ||
| <directory>src</directory> | ||
| </include> | ||
|
|
||
| <deprecationTrigger> | ||
| <function>trigger_deprecation</function> | ||
| <method>Doctrine\Deprecations\Deprecation::trigger</method> | ||
| <method>Doctrine\Deprecations\Deprecation::delegateTriggerToBackend</method> | ||
| </deprecationTrigger> | ||
| </source> | ||
| </phpunit> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| <?xml version="1.0"?> | ||
| <psalm | ||
| errorLevel="2" | ||
| resolveFromConfigFile="true" | ||
| xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
| xmlns="https://getpsalm.org/schema/config" | ||
| xsi:schemaLocation="https://getpsalm.org/schema/config vendor/vimeo/psalm/config.xsd" | ||
| findUnusedCode="false" | ||
| findUnusedBaselineEntry="true" | ||
| > | ||
| <projectFiles> | ||
| <directory name="src" /> | ||
| <directory name="config" /> | ||
| <ignoreFiles> | ||
| <directory name="vendor" /> | ||
| </ignoreFiles> | ||
| </projectFiles> | ||
|
|
||
| <issueHandlers> | ||
| <ImplicitToStringCast errorLevel="suppress" /> | ||
| </issueHandlers> | ||
| </psalm> |
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this
SymfonyDocsBuildernamespace still used ?