android: fix ktfmt for agp 9.4 - #873
Conversation
There was a problem hiding this comment.
@hiimtmac Does ktfmt have rules like SwiftLint where we might be able to override some if it's more colourful choices like not liking single line if statements or trailing brackets? At some point, those were acceptable formatting to it. I dislike that this touched everything (and I didn't look carefully - we use ktfmt so I will defer to its new choices).
If we have to to, we might as well rip off the bandaid. I didn't check every change - but if it still compiles - merge it.
68e5a99 to
523192e
Compare
Fixes tailscale/corp#48331 Signed-off-by: Taylor McIntyre <taylorm@tailscale.com>
523192e to
032ee8f
Compare
|
Fixes tailscale/corp#48331
Upgrade the ktfmt Gradle plugin from 0.17.0 to 0.27.0 for compatibility with AGP 9.4. With 0.17.0,
ktfmtCheckhad no actions because the plugin did not discover AGP 9.4’s Kotlin source. Version 0.27.0 correctly registers and runs the source-set-specific ktfmt tasks.The plugin upgrade also moves the bundled ktfmt engine from 0.47 to 0.64, so this PR includes the resulting one-time formatting changes. CI continues to run
ktfmtCheckacross all Kotlin source sets (not just what is changed in the PR).