Conversation
cygnusv
force-pushed
the
advisory-fix-1
branch
from
November 24, 2023 16:52
9a5c361 to
60bf211
Compare
|
Solidity API documentation preview available in the artifacts of the https://github.com/threshold-network/solidity-contracts/actions/runs/6983216791 check. |
cygnusv
force-pushed
the
advisory-fix-1
branch
from
November 28, 2023 10:10
60bf211 to
3548b65
Compare
|
Solidity API documentation preview available in the artifacts of the https://github.com/threshold-network/solidity-contracts/actions/runs/7017206666 check. |
|
Solidity API documentation preview available in the artifacts of the https://github.com/threshold-network/solidity-contracts/actions/runs/7017401128 check. |
cygnusv
force-pushed
the
advisory-fix-1
branch
from
November 28, 2023 10:30
f20d988 to
c8e5825
Compare
|
Solidity API documentation preview available in the artifacts of the https://github.com/threshold-network/solidity-contracts/actions/runs/7017438377 check. |
Implementation: 0x409bf77A8E3Fe384497227eA508029B5364933DE See https://etherscan.io/tx/0x1aaed6d9505e1bd79e5724aefe9464258108d35bb728938ccb16c9dd7eb10540/advanced#eventlog
After #153, which drop support for legacy stakers, TokenStaking constructor requires less arguments
New implementation: 0x4d333B9ECB75252342d82B7aF3610951f81e0888 See https://etherscan.io/tx/0x68ddee6b5651d5348a40555b0079b5066d05a63196e3832323afafae0095a656
This is not strictly necessary, but can help to avoid some social engineering attacks
Ideally, this should be automated, but this is a start
cygnusv
force-pushed
the
advisory-fix-1
branch
from
September 9, 2024 15:23
c8e5825 to
6ec3ad0
Compare
mswilkison
added a commit
that referenced
this pull request
Sep 8, 2026
Copy both historical implementation records unchanged from advisory-fix-1 at 6ec3ad0. Validate the creation transactions, constructor arguments, implementation version keys, compiled bytecode, and storage layouts before retiring the obsolete mainnet upgrade proposal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This mainnet TokenStaking upgrade proposal is obsolete following the retirement of the contract and its proxy.
The two unique historical implementation records from this branch are preserved unchanged in #173, commit 487e5e7. Validation confirmed their creation transactions, constructor arguments, manifest version hashes, reproduced creation bytecode, normalized runtime bytecode, and compiled storage layouts. Their creation dates are May 11 and November 20, 2023; the original proposal separately reports a November 22 upgrade date.
Active Sepolia upgrade tooling continues in #176, consumer proxy deployment support in #186, and supported verification in #185 coordinated with #182. Retained deployment scripts and tests still use the OpenZeppelin upgrades dependency. This proposal's mainnet upgrade scripts and dedicated CI are retired; the branch remains available as a historical reference.
Original proposal: