Upgrade Slither CI to 0.11.6 - #188
Open
mswilkison wants to merge 2 commits into
Open
mswilkison wants to merge 2 commits into
mswilkison wants to merge 2 commits into
Conversation
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #187.
Upgrade CI from Slither 0.8.0 to 0.11.6, with crytic-compile 0.4.2 and solc-select 1.2.0 pinned in
requirements-slither.txt. The job uses Python 3.13, checks Python dependency consistency, and logs the resolved toolchain. The README includes local setup and an upgrade procedure. The documented.venv-slither/is excluded from both Git and Prettier, so formatting commands skip installed Python dependencies.This PR is stacked on #182 (
chore/dependency-toolchain-refresh, base14843ac). Merge #182 first, then retarget this PR tomain. It uses that PR's Node 22 / Hardhat 2 / Ethers 5 toolchain.Slither completes with the OpenZeppelin upgrades plugin enabled, resolving the historical crash that blocked #96. All Solidity edits are comments: remove 13 obsolete suppressions and document four narrowly scoped suppressions. The internal
SafeTUpgradeable.safeTransferFromadapter's two callers passmsg.sender; the three unindexed-event notices retain the existing event ABI and log encoding. Existing detector/path exclusions and the default failure policy are preserved.Validation:
yarn install --frozen-lockfileandpython -m pip checkpass.slither .performs a clean compilation and finishes with 0 findings across 84 contracts and 95 detectors.yarn build,yarn test(380 passing), andyarn format(including type checking) pass.git diff --checkpass.node_modules/@thesis/solidity-contracts/contracts/token/ERC20WithPermit.sol(reported twice); repository-owned directives are clean.Local runtime: Python 3.13.7, Node 22.23.1, Yarn 1.22.22. CI used Python 3.13.15 and confirmed 0 Slither findings, compilation of 75 Solidity files, and 380 passing tests.
GitHub Actions passed on
20a20d5: Solidity build/tests, Slither, and deployment dry run, formatting and type checks, and documentation preview.