Make the legacy Keep deployment key optional - #192
Open
mswilkison wants to merge 1 commit into
Open
mswilkison wants to merge 1 commit into
mswilkison wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting only
CONTRACT_OWNER_ACCOUNT_PRIVATE_KEYmakes Hardhat reject the Sepolia account list because its second entry is undefined. Hardhat validates every configured network, so this also prevents commands targeting mainnet from starting. The original Ropsten failure in #84 survives in the current Sepolia configuration.Include the legacy Keep key only when it is nonempty. When both keys are set, the deployment account remains first and the Keep account remains second. When the deployment key is absent, retain RPC-managed accounts; malformed supplied keys still fail validation.
Validation: seven regression checks load the actual project configuration through Hardhat's validator with synthetic keys and no provider initialization. The three missing/empty-key cases fail on the base revision; all seven pass with this change. Modified-file JavaScript lint, Prettier, and
git diff --checkpass.GitHub Actions passed on
28c367f: contract build, all 387 tests, deployment dry run, and Slither, plus formatting checks.Closes #84.