Use Threshold-owned CI and release actions - #195
Open
mswilkison wants to merge 3 commits into
Open
mswilkison wants to merge 3 commits into
mswilkison wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the maintained actions from threshold-network/ci #1, pinned to
20b35345d276a3c7365e3829b8078387a7c9dccb. This includes the vendored npm-version-bump action. Completion payloads and upstream-build queries use the Threshold module identifiers configured by the new release manager.Update obsolete action runtimes in the affected workflows. Artifact uploads preserve hidden deployment metadata when moving to artifact v4. The producer and all consumer migrations must merge before starting a new inter-repository release pipeline;
CI_GITHUB_TOKENmust be configured where missing. npm/cloud/docs credentials stay in their existing consumer repositories.Validation: actionlint passes for every changed workflow; producer paths, input names, commit pins, dispatch input contracts, and module/query identifiers were checked against the producer. Its 51 tests and four standalone action-bundle checks pass in GitHub CI. Release/deployment/publishing paths were not invoked during validation.
The shared docs workflow is now owned and pinned. These changes are independent of the helper and lint-config migrations in #193 and #194.
The docs caller selects Node 18.20.8 because this repository still locks Hardhat 2.10.2; the maintained action runtime remains Node 24. The shared workflow exposes the build Node version as a consumer input.
Serialize the CI build’s compiler jobs (
--concurrency 1) while the locked OpenZeppelin upgrades plugin remains at 1.14.0. Its validation cache has an unguarded read/merge/write: invoking the installed plugin on three real compiler results concurrently retained only one result and lostSimpleStorage; serial writes retained all three. This matches the proxy test failure observed twice in CI. A clean serial build preserves all 84 contract artifact files byte-for-byte and the complete validation cache. All 380 tests pass after the clean serial build. Contract code, compiler settings, and dependency versions are unchanged.