trunk-merge/pr-1205/c7ef6a77-b817-42eb-a91d-0aad752700fc - #1206
Closed
trunk-io[bot] wants to merge 2 commits into
Closed
trunk-io[bot] wants to merge 2 commits into
trunk-io[bot] wants to merge 2 commits into
Conversation
A forked `pull_request` run gets no repository secrets, so it can present neither an org token nor (for a collection-first org) a public repo id. `--allow-forked-pr-uploads` / `TRUNK_ALLOW_FORKED_PR_UPLOADS` opts such a run into a lane authorized server-side by the test collection's own opt-in, using the `--test-collection-id` the workflow already passes. The flag is a mode selector, not a credential — it is sent as `x-trunk-allow-forked-pr-uploads: true` and grants nothing on its own. Requiring it is the point: without it, "no token" would silently become an anonymous upload, and because this lane fails open on authorization errors the misconfiguration would surface as a warning and a green CI step. A job whose `TRUNK_API_TOKEN` secret fails to interpolate still errors out. It also errors early when set without `--test-collection-id`: there would be nothing for the server to authorize against, and that failure is far clearer at arg-parse time than as a 401 the run then swallows. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1206 +/- ##
==========================================
+ Coverage 83.70% 83.96% +0.25%
==========================================
Files 74 74
Lines 17667 17745 +78
==========================================
+ Hits 14789 14899 +110
+ Misses 2878 2846 -32 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
trunk-io
Bot
deleted the
trunk-merge/pr-1205/c7ef6a77-b817-42eb-a91d-0aad752700fc
branch
September 24, 2026 17:23
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request was created and is being managed by Trunk Merge.
This pull request is based on the main branch at SHA 266f3051ce4e223b70e8364bcb800af5ada1dd04.
See more details here.
When CI completes, this pull request will be closed automatically.
Pull Requests Being Tested
This pull request is testing the changes from pull request 1205.