fix: set StartupWMClass in the Linux desktop entry - #1393
Merged
Merged
Conversation
Docks such as GNOME's match a running window to its .desktop entry by StartupWMClass or, failing that, by the entry's basename. Pake installs com.pake.<name>.desktop but the window reports the binary name (pake-<name>) as its WM_CLASS and Wayland app_id, so neither matched and the dock showed a generic icon with no pinned entry. Emit StartupWMClass=<binary name> so the two line up. tw93#1388
Owner
|
@drakeo338 Thanks for tracking down the WM_CLASS mismatch, merged. The generated desktop entry now carries the same It ships in the next pake-cli release; apps need a rebuild with that version to pick it up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1388.
Pake's Linux
.desktopentry didn't setStartupWMClass, so docks like GNOME's that match a running window to its launcher by that field (or by the entry's basename as a fallback) couldn't find a match: the window reportspake-<name>as its WM_CLASS/app_id while the entry iscom.pake.<name>.desktop. The dock then falls back to a generic icon and no pinned entry works correctly. This addsStartupWMClass=<binary name>to the generated entry so the two line up, plus a unit test covering it.