fix for test case macro guards - #11525
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
Review effort: Lite
Findings: 1
Open (2)
What changed in this PR
Updates TLS parse unit tests’ preprocessor guards to avoid compilation failures in certain static-build feature combinations (e.g., nightly memusage Jenkins builds), primarily by tightening #if conditions and adjusting where shared test variables are declared.
Changes:
- Adds
(!defined(NO_RSA) || defined(HAVE_ECC))gating to several TLS 1.2/1.3 test blocks so they are excluded when neither RSA nor ECC is available. - Moves
ext/extLendeclarations intest_TLSX_PointFormat_parse()behind a broader conditional so both TLS 1.2 and TLS 1.3 sections can reference them. - Applies similar guard tightening to additional tests (e.g., supported versions parse, keyshare negotiate).
| File | Description |
|---|---|
| tests/api/test_tls_parse.c | Adjusts compile-time guards and variable scoping in TLS parse tests to fix static-build configurations that previously failed to compile. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
philljj
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Fix for nightly-memusage Jenkins builds.
./configure --disable-shared --disable-rsa --disable-ecc --disable-dh --enable-curve25519 --enable-ed25519 --enable-tls13 && make