Skip to content

fix for test case macro guards - #11525

Merged
philljj merged 1 commit into
wolfSSL:masterfrom
JacobBarthelmeh:nightly
Sep 23, 2026
Merged

philljj merged 1 commit into
wolfSSL:masterfrom
JacobBarthelmeh:nightly

Conversation

@JacobBarthelmeh

Copy link
Copy Markdown
Contributor

Fix for nightly-memusage Jenkins builds.

./configure --disable-shared --disable-rsa --disable-ecc --disable-dh --enable-curve25519 --enable-ed25519 --enable-tls13 && make

tests/api/test_tls_parse.c:1548:42: error: use of undeclared identifier 'ext'
1548 |             ExpectIntEQ(TLSX_Parse(sslp, ext, extLen, client_hello, suites),
    |                                          ^
tests/api/test_tls_parse.c:1548:47: error: use of undeclared identifier 'extLen'
1548 |             ExpectIntEQ(TLSX_Parse(sslp, ext, extLen, client_hello, suites),
    |                                               ^
CC       tests/api/unit_test-test_ossl_bn.o

@JacobBarthelmeh JacobBarthelmeh self-assigned this Sep 22, 2026
Copilot AI lite review requested due to automatic review settings September 22, 2026 20:50
@JacobBarthelmeh JacobBarthelmeh added the For This Release Release version 5.9.4 label Sep 22, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Copilot review overview

Review effort: Lite
Findings: 1 High severity · 1 Medium severity

Open (2)
What changed in this PR

Updates TLS parse unit tests’ preprocessor guards to avoid compilation failures in certain static-build feature combinations (e.g., nightly memusage Jenkins builds), primarily by tightening #if conditions and adjusting where shared test variables are declared.

Changes:

  • Adds (!defined(NO_RSA) || defined(HAVE_ECC)) gating to several TLS 1.2/1.3 test blocks so they are excluded when neither RSA nor ECC is available.
  • Moves ext / extLen declarations in test_TLSX_PointFormat_parse() behind a broader conditional so both TLS 1.2 and TLS 1.3 sections can reference them.
  • Applies similar guard tightening to additional tests (e.g., supported versions parse, keyshare negotiate).
File Description
tests/​api/​test_tls_parse.c Adjusts compile-time guards and variable scoping in TLS parse tests to fix static-build configurations that previously failed to compile.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread tests/api/test_tls_parse.c
Comment thread tests/api/test_tls_parse.c
@philljj
philljj merged commit d95483f into wolfSSL:master Sep 23, 2026
387 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

For This Release Release version 5.9.4

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants