You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This pull request adds a native Windows ARM64 job to the existing CI workflow.
The change introduces a configuration that runs on the windows-11-arm runner and builds
flac using ARM64 as the target platform. The changes are added to:
action.yml
msys2.yml
No existing CI jobs or platforms are modified.
This is a minimal, additive change intended to improve CI coverage for Windows on ARM and enable native Windows ARM64 builds.
No worries on the ping, but just to set expectations: I'm not a maintainer here. My only involvement was a small CI-hardening patch (#908), and I have no merge rights, so please don't wait on me for this one. @ktmf01 is the maintainer who reviews and merges, so this PR needs their eyes.
Not a maintainer, but since I touched these workflows recently (#908) I took a proper look. Reviewing as a contributor in case it helps move this along.
The change itself looks sound:
action.yml: the four windows-11-arm-* cmake entries mirror the existing windows-latest-* cmake variants one-for-one (plain / shared / c11 / c11-shared), so the matrix stays consistent and the footprint is proportionate rather than excessive.
msys2.yml: converting the single job into an x64 + arm64 matrix is the right shape, and clangarm64 is the correct MSYS2 environment for native ARM64.
A few things worth resolving before it can go green:
The actual blocker is that CI has not run on the current head. This is a PR from a fork, so the ARM64 jobs need a maintainer to approve the workflow run before anyone can see whether they build. Until that happens there is no signal on whether flac actually compiles and tests clean on windows-11-arm, which is the whole point of the PR. That approval is the single thing that would move this forward.
choco install pandoc is the most likely place the arm64 msys2 job falls over. The Chocolatey pandoc package is an x64 build, so on windows-11-arm it runs through x64 emulation, which is at best slow and at worst not present on the runner. Since pandoc is only needed for the man pages (which are architecture independent and already built on the x64 job), the cleanest fix is probably to skip the pandoc step on the arm64 leg, or gate the docs build on matrix.arch == 'x64'.
The branch is three commits behind master and was cut before the recent workflow updates landed (permissions: read-all, and actions/checkout / actions/upload-artifact bumped to v7). A normal merge preserves those since this PR does not touch those lines, but a rebase on master is still worth doing so the new ARM64 jobs run against the current workflow rather than the older one.
Minor: msys2.yml loses its trailing newline in this diff.
Happy to help test the pandoc-on-arm64 behaviour if that is useful.
Hi @Alb3e3, thank you for the suggestions. That was very helpful! @ktmf01, do let us know if the changes look fine to you and how we can proceed from here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
This pull request adds a native Windows ARM64 job to the existing CI workflow.
The change introduces a configuration that runs on the
windows-11-armrunner and buildsflac using ARM64 as the target platform. The changes are added to:
No existing CI jobs or platforms are modified.
This is a minimal, additive change intended to improve CI coverage for Windows on ARM and enable native Windows ARM64 builds.