Skip to content

test-appstream.sh: If Appstream XML doesn't match, show its content - #781

Merged
bbhtt merged 2 commits into
flatpak:flatpak-builder-1.4.xfrom
smcv:appstream-regex
Sep 15, 2026
Merged

bbhtt merged 2 commits into
flatpak:flatpak-builder-1.4.xfrom
smcv:appstream-regex

Conversation

@smcv

@smcv smcv commented Sep 15, 2026

Copy link
Copy Markdown
Contributor
  • libtest.sh: Add assert_file_has_content_extended

    This is the same as assert_file_has_content, but uses POSIX extended
    regexps (grep -E) instead of basic regexps (plain grep).

  • test-appstream.sh: If Appstream XML doesn't match, show its content

    This made it feasible to diagnose Tests fail with libappstream 1.2.0 #776.


Originally part of #778. Can be retargeted to main if preferred, but only after #779 gets applied to main.

This is the same as assert_file_has_content, but uses POSIX extended
regexps (`grep -E`) instead of basic regexps (plain `grep`).

Signed-off-by: Simon McVittie <smcv@debian.org>
This made it feasible to diagnose flatpak#776.

Signed-off-by: Simon McVittie <smcv@debian.org>
@bbhtt
bbhtt merged commit 1da33b6 into flatpak:flatpak-builder-1.4.x Sep 15, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants