refactor(pager): unify dashboard, node and channel rows by ericlewis · Pull Request #406 · meshtastic/device-ui

ericlewis · 2026-09-17T18:57:41Z

Summary

Give Home, Nodes, Groups and active chats consistent full-width rounded rows with visible inset focus outlines and scrollbars at the right edge.
Place node long names below their short names and give every channel a fallback icon and label.
Keep dynamically added node rows selectable and hide or restore channel rows when their enabled state changes.

Implementation

Depends on #405. Merge/review order: #405 → #406 → #409 → #407 → #408. These are cumulative stages on the upstream pager branch at f31965d. Dependent PRs include earlier stages until those changes reach pager; use the focused comparison below to review this contribution.

Focused diff: #405 → #406. Reuse the shared ListRowStyle in the native DashboardPlugin, NodesPlugin, GroupsPlugin and ScrollMenuPlugin, plus the 480 × 222 chat-row factory. No generated screen assets are edited.

Dashboard labels become row content while existing runtime icon/state updates remain authoritative. Node creation and refresh share one row binding/layout path, preserving the image/short-name/long-name child order used by conversation headings. Channel refresh updates visibility and naming without recreating the screen. Menu actions use short clicks so long presses do not also trigger navigation.

Testing

Combined native tlora-pager-tft firmware build passed: pio run -e tlora-pager-tft -t mtjson, using firmware 6013049 and the public UI archive e9c8eee. All 648 tracked archive files match that UI snapshot; all four manifest artifact sizes and checksums matched.
This validates the complete combined implementation, not independent builds of each intermediate PR stage.
Automated tests: Not run. The native plugin firmware has not been flashed; hardware validation is pending.

Risks

Reparented dashboard labels and runtime-created node/channel rows need on-device focus, scrolling and long-name checks. The shared styling changes plugin layouts beyond the Pager where those plugins are reused; other display sizes have not been validated.

* Create: da.yml - full Danish translation * Add: Danish translation + sort list of translations

* added Danish language support * trunk fmt

Co-authored-by: mverch67 <71137295+mverch67@users.noreply.github.com>

* handle custom lora preset/frequency * trunk fmt

Co-authored-by: mverch67 <71137295+mverch67@users.noreply.github.com>

This reverts commit bf7668b.

* Explain the file system to format to * Remove MBR section I believe MBR is not relevant at all * Add back MBR (also known as msdos)

* Map compatibility information * Add compatibility information for CrowPanel Advance HMI --------- Co-authored-by: Manuel <71137295+mverch67@users.noreply.github.com>

Co-authored-by: mverch67 <71137295+mverch67@users.noreply.github.com>

see https://github.com/lovyan03/LovyanGFX/blob/2e0dc974a9b6521bf155afb53a9a92a623a60803/src/lgfx/v1/panel/Panel_NV3041A.hpp#L60

feat: Support 4.3" TFT display JC4827W543C

Co-authored-by: mverch67 <71137295+mverch67@users.noreply.github.com>

* add time zone offset * reverse order new chats

CLAassistant · 2026-09-17T18:57:58Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
7 out of 9 committers have signed the CLA.

✅ thebentern
✅ p0ns
✅ mverch67
✅ ericlewis
✅ zmiguel
✅ t-miura
✅ caveman99
❌ pisti87
❌ github-actions[bot]
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

Copilot

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Pull request overview

Adds Pager-specific shared row styling and layout for Home, Nodes, and Groups, including full-width rows, shared focus outlines, node name arrangement, and placeholder icons for unused channels.

Changes:

Introduces reusable Pager row focus and styling helpers.
Restructures Home and Group controls for full-width row layouts and adjusted scrollbar placement.
Updates Node labels, channel icons, distance formatting, and theme behavior for T_LORA_PAGER.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
`source/graphics/TFT/Themes.cpp`	Preserves Pager row text styling for enabled controls.
`source/graphics/TFT/TFTView_320x240.cpp`	Applies Pager layouts and updates Node, channel, distance, and icon behavior.
`include/graphics/view/TFT/PagerListRow.h`	Adds shared row styling and focus forwarding.
`include/graphics/view/TFT/PagerHomeList.h`	Defines Home, Group, and Node Pager-specific layouts.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

+        lv_obj_set_flex_flow(row.button, LV_FLEX_FLOW_ROW);
+        lv_obj_set_flex_align(row.button, LV_FLEX_ALIGN_START, LV_FLEX_ALIGN_CENTER, LV_FLEX_ALIGN_CENTER);
+
+        lv_obj_t *icon = lv_obj_create(row.button);


+        lv_obj_set_parent(row.label, row.button);
+        lv_obj_set_pos(row.label, 0, 0);
+        lv_obj_set_size(row.label, 0, LV_SIZE_CONTENT);
+        lv_obj_set_flex_grow(row.label, 1);


+    }
+
+    // Signal quality was positioned inside the old label using a fixed offset.
+    lv_obj_set_parent(objects.home_signal_pct_label, objects.home_signal_button);


Prepared offline from e9c8eee.

Reconcile the published contribution with the native Pager plugin branch. Preserve the existing PR history and the cumulative dependency stage.

Retain the published PR head and the preceding cumulative PR as parents. Keep the intended feature-stage tree unchanged.

mverch67 and others added 30 commits August 21, 2025 18:26

I2C keyboard scanner + cardkb

2ec7aa6

scan all keyboards

e09f33d

request input from all keyboards

bb0305d

CardKB Fn+ENTER: simulate LONG PRESS

4120009

add support for JC4827W543C

3b8cb55

Merge branch 'master' into JC4827W543C

d9eef22

Merge branch 'master' into JC4827W543C

9733d5e

feat: Danish translation (meshtastic#211)

733a453

* Create: da.yml - full Danish translation * Add: Danish translation + sort list of translations

feat: Danish language support (meshtastic#212)

f0fb16c

* added Danish language support * trunk fmt

Upgrade trunk (meshtastic#205)

505ffad

Co-authored-by: mverch67 <71137295+mverch67@users.noreply.github.com>

bell icons for fix-189

f920b12

disable alert per channel (meshtastic#214)

d023004

Upgrade trunk (meshtastic#213)

e564d78

Co-authored-by: mverch67 <71137295+mverch67@users.noreply.github.com>

fix initial GPS position (meshtastic#219)

c3d997e

Upgrade trunk (meshtastic#216)

6d8cc22

Co-authored-by: mverch67 <71137295+mverch67@users.noreply.github.com>

feat: handle custom lora preset/frequency (meshtastic#221)

bf7668b

* handle custom lora preset/frequency * trunk fmt

Upgrade trunk (meshtastic#220)

45788ce

Co-authored-by: mverch67 <71137295+mverch67@users.noreply.github.com>

Revert "feat: handle custom lora preset/frequency (meshtastic#221)"

bb6e4a7

This reverts commit bf7668b.

restore changes for meshtastic#221

a6d5bd1

update to new protobufs (is_muted) (meshtastic#223)

3fb7c0e

docs: SD card explain file system (meshtastic#225)

19b7855

* Explain the file system to format to * Remove MBR section I believe MBR is not relevant at all * Add back MBR (also known as msdos)

add heltec-v4-tft code. (meshtastic#231)

28167c6

docs: Map compatibility information meshtastic#233 (meshtastic#235)

adf1d5f

* Map compatibility information * Add compatibility information for CrowPanel Advance HMI --------- Co-authored-by: Manuel <71137295+mverch67@users.noreply.github.com>

Upgrade trunk (meshtastic#222)

3bf3322

Co-authored-by: mverch67 <71137295+mverch67@users.noreply.github.com>

Merge branch 'master' into JC4827W543C

65c6a79

Fix init_cmds array size for Panel_NV3041A

d33c98d

see https://github.com/lovyan03/LovyanGFX/blob/2e0dc974a9b6521bf155afb53a9a92a623a60803/src/lgfx/v1/panel/Panel_NV3041A.hpp#L60

Merge pull request meshtastic#188 from meshtastic/JC4827W543C

4fb5f24

feat: Support 4.3" TFT display JC4827W543C

add time zone offset (meshtastic#242)

39c62eb

Upgrade trunk (meshtastic#236)

d8afe17

Co-authored-by: mverch67 <71137295+mverch67@users.noreply.github.com>

feat: new chats at top (meshtastic#243)

2746a1c

* add time zone offset * reverse order new chats

ericlewis added 2 commits September 17, 2026 17:05

feat(pager): align Groups and Node rows with Home

b5ec75e

fix(ui): focus visible chats and message restoration

ac63f33

ericlewis changed the title ~~feat(pager): share list rows and focus styling across Home and Nodes~~ feat(pager): share list rows across Home, Nodes and Groups Sep 17, 2026

ericlewis added 6 commits September 17, 2026 18:06

feat(ui): add a saved double-space period setting

8c18640

fix(ui): scroll message history with the encoder

6d9be74

fix(ui): send messages after automatic period insertion

ca1016d

refactor(ui): remove timestamps from message bubbles

766a435

fix(ui): size message bubbles with the displayed font

4381db6

feat(pager): include core keyboard and landscape support

c9ddf6c

ericlewis marked this pull request as ready for review September 18, 2026 02:07

Copilot AI lite review requested due to automatic review settings September 18, 2026 02:07

ericlewis marked this pull request as draft September 18, 2026 02:20

Copilot AI reviewed Sep 18, 2026

View reviewed changes

ericlewis added 7 commits September 17, 2026 22:42

fix(pager): improve physical input and conversation behavior

702b08b

Prepared offline from e9c8eee.

fix(pager): share plugin styles and platform compatibility

6658e72

Prepared offline from e9c8eee.

refactor(pager): use coherent dashboard and conversation rows

81ea5e4

Prepared offline from e9c8eee.

merge(pager): integrate PR 405 source partition

b44c366

Prepared offline from e9c8eee.

merge(pager): integrate PR 406 source partition

b4e9278

Prepared offline from e9c8eee.

fix(pager): improve physical input and conversation behavior

312f70c

Reconcile the published contribution with the native Pager plugin branch. Preserve the existing PR history and the cumulative dependency stage.

refactor(pager): use coherent dashboard and conversation rows

1560d6f

Reconcile the published contribution with the native Pager plugin branch. Preserve the existing PR history and the cumulative dependency stage.

ericlewis changed the base branch from master to pager September 18, 2026 02:58

merge(pager): preserve cumulative PR ancestry for meshtastic#406

8830a7b

Retain the published PR head and the preceding cumulative PR as parents. Keep the intended feature-stage tree unchanged.

ericlewis mentioned this pull request Sep 18, 2026

feat(pager): deliver local GPS status to the native plugin UI meshtastic/firmware#11892

Open

ericlewis changed the title ~~feat(pager): share list rows across Home, Nodes and Groups~~ refactor(pager): unify dashboard, node and channel rows Sep 18, 2026

This was referenced Sep 18, 2026

feat(pager): show live local GPS receiver status #409

Open

feat(pager): share settings editors and apply live UI updates #407

Open

feat(pager): add map controls, caching and tile status #408

Open

ericlewis marked this pull request as ready for review September 18, 2026 03:02

Copilot started reviewing on behalf of ericlewis September 18, 2026 03:11 View session

Navigation Menu

Uh oh!

refactor(pager): unify dashboard, node and channel rows - #406

refactor(pager): unify dashboard, node and channel rows#406
ericlewis wants to merge 211 commits into
meshtastic:pagerfrom
ericlewis:codex/pager-home-list

ericlewis commented Sep 17, 2026 •

edited

Loading

Uh oh!

CLAassistant commented Sep 17, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

17 participants

Uh oh!

Conversation

ericlewis commented Sep 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Implementation

Testing

Risks

Uh oh!

CLAassistant commented Sep 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

17 participants

ericlewis commented Sep 17, 2026 •

edited

Loading

CLAassistant commented Sep 17, 2026 •

edited

Loading