feat(pager): show live local GPS receiver status by ericlewis · Pull Request #409 · meshtastic/device-ui

ericlewis · 2026-09-17T21:28:09Z

Summary

Show whether the local GPS receiver is unavailable, searching, sleeping or has a fix, independently of mesh position broadcasts.
Display satellites used with freshness information and retain the last accepted position during receiver sleep.
Preserve configured fixed positions and fall back to existing packet-derived data when local receiver status is unavailable.

Implementation

Depends on #406. Merge/review order: #405 → #406 → #409 → #407 → #408. These are cumulative stages on the upstream pager branch at f31965d. Dependent PRs include earlier stages until those changes reach pager; use the focused comparison below to review this contribution.

Focused diff: #406 → #409. An optional LocalGPSStatus snapshot flows from PacketServer through the shared queue and PacketClient to ViewController, PluggableView and DashboardPlugin.

The shared snapshot is mutex-protected and coalesced rather than appended to the packet backlog. The controller polls on elapsed milliseconds, independently of wall-clock synchronization. Satellite counts represent GGA satellites used, not all satellites visible; stale counts are labelled as last known values. At this stage, coordinates continue through the existing MapPanel interface; #408 supplies the map plugin.

The producer is meshtastic/firmware#11892. Clients without this optional in-process hook retain their existing behavior. No protobuf schema or radio protocol changes are introduced.

Testing

Combined native tlora-pager-tft firmware build passed: pio run -e tlora-pager-tft -t mtjson, using firmware 6013049 and the public UI archive e9c8eee. All 648 tracked archive files match that UI snapshot; all four manifest artifact sizes and checksums matched.
This validates the complete combined implementation, not independent builds of each intermediate PR stage.
Automated tests: Not run. The native plugin firmware has not been flashed; hardware validation is pending.

Risks

Live receiver details require the firmware companion. Receiver sleep/wake, fix loss, satellite freshness and fixed-position precedence still need native Pager hardware verification; the combined build does not prove GPS reception.

* Create: da.yml - full Danish translation * Add: Danish translation + sort list of translations

* added Danish language support * trunk fmt

Co-authored-by: mverch67 <71137295+mverch67@users.noreply.github.com>

* handle custom lora preset/frequency * trunk fmt

Co-authored-by: mverch67 <71137295+mverch67@users.noreply.github.com>

This reverts commit bf7668b.

* Explain the file system to format to * Remove MBR section I believe MBR is not relevant at all * Add back MBR (also known as msdos)

* Map compatibility information * Add compatibility information for CrowPanel Advance HMI --------- Co-authored-by: Manuel <71137295+mverch67@users.noreply.github.com>

Co-authored-by: mverch67 <71137295+mverch67@users.noreply.github.com>

see https://github.com/lovyan03/LovyanGFX/blob/2e0dc974a9b6521bf155afb53a9a92a623a60803/src/lgfx/v1/panel/Panel_NV3041A.hpp#L60

feat: Support 4.3" TFT display JC4827W543C

Co-authored-by: mverch67 <71137295+mverch67@users.noreply.github.com>

* add time zone offset * reverse order new chats

Copilot

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Pull request overview

Adds a process-local “live GPS receiver status” path from the packet layer to the Pager UI so receiver availability/sleep/fix/satellite freshness can update independently from position packets and broadcast intervals.

Changes:

Introduces LocalGPSStatus snapshot and a coalesced, mutex-protected handoff via SharedQueue.
Adds a client accessor and controller polling (monotonic millis() cadence) to push status into the UI.
Updates Pager rendering to show receiver state + freshness and avoid overwriting satellite labels with altitude-only text.

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
include/util/LocalGPSStatus.h	Defines the snapshot struct for local receiver state.
include/util/SharedQueue.h	Adds mutex-protected storage for the latest `LocalGPSStatus`.
source/util/SharedQueue.cpp	Implements set/get for the coalesced GPS status snapshot.
include/comms/PacketServer.h	Exposes `setLocalGPSStatus()` for producers.
source/comms/packet/PacketServer.cpp	Forwards GPS status writes into `SharedQueue`.
include/comms/IClientBase.h	Adds optional `getLocalGPSStatus()` accessor with a safe default.
include/comms/PacketClient.h	Declares client-side `getLocalGPSStatus()` override.
source/comms/packet/PacketClient.cpp	Implements reading GPS status from `SharedQueue`.
include/graphics/common/MeshtasticView.h	Adds `updateLocalGPSStatus()` view hook.
include/graphics/common/ViewController.h	Adds poll timestamp state.
source/graphics/common/ViewController.cpp	Polls local GPS status on a monotonic 1s cadence and updates the view.
include/graphics/view/TFT/TFTView_320x240.h	Pager-only fields + override for live GPS status updates.
source/graphics/TFT/TFTView_320x240.cpp	Pager-only rendering of receiver status + updated position/satellite label behavior.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

+        if (!pagerGPSStatusKnown && sats != 0)
+            pagerPacketSatellites = sats;
+        if (lat != 0 || lon != 0 || (pagerGPSStatusKnown && pagerGPSStatus.hasPosition))
+            pagerGPSDetails = buf;
+        renderPagerGPSStatus();


+    const bool positionChanged = !pagerGPSStatusKnown || !pagerGPSStatus.hasPosition ||
+                                 pagerGPSStatus.latitude_i != status.latitude_i ||
+                                 pagerGPSStatus.longitude_i != status.longitude_i || pagerGPSStatus.altitude != status.altitude ||


+        // Receiver freshness must keep advancing across RTC corrections.
+        const uint32_t nowMs = millis();
+        if (nowMs - lastGPSPollMs >= 1000) {
+            lastGPSPollMs = nowMs;
+            LocalGPSStatus gpsStatus;
+            if (setupDone && configCompleted && client->getLocalGPSStatus(gpsStatus))
+                view->updateLocalGPSStatus(gpsStatus);
+        }


+    if (enabled && pagerGPSStatusKnown) {
+        char satellites[64];
+        if (pagerGPSStatus.satellitesValid) {
+            const bool current = pagerGPSStatus.awake && pagerGPSStatus.satellitesAgeMs < 5000;


Prepared offline from e9c8eee.

Reconcile the published contribution with the native Pager plugin branch. Preserve the existing PR history and the cumulative dependency stage.

Retain the published PR head and the preceding cumulative PR as parents. Keep the intended feature-stage tree unchanged.

mverch67 and others added 30 commits August 21, 2025 18:26

I2C keyboard scanner + cardkb

2ec7aa6

scan all keyboards

e09f33d

request input from all keyboards

bb0305d

CardKB Fn+ENTER: simulate LONG PRESS

4120009

add support for JC4827W543C

3b8cb55

Merge branch 'master' into JC4827W543C

d9eef22

Merge branch 'master' into JC4827W543C

9733d5e

feat: Danish translation (meshtastic#211)

733a453

* Create: da.yml - full Danish translation * Add: Danish translation + sort list of translations

feat: Danish language support (meshtastic#212)

f0fb16c

* added Danish language support * trunk fmt

Upgrade trunk (meshtastic#205)

505ffad

Co-authored-by: mverch67 <71137295+mverch67@users.noreply.github.com>

bell icons for fix-189

f920b12

disable alert per channel (meshtastic#214)

d023004

Upgrade trunk (meshtastic#213)

e564d78

Co-authored-by: mverch67 <71137295+mverch67@users.noreply.github.com>

fix initial GPS position (meshtastic#219)

c3d997e

Upgrade trunk (meshtastic#216)

6d8cc22

Co-authored-by: mverch67 <71137295+mverch67@users.noreply.github.com>

feat: handle custom lora preset/frequency (meshtastic#221)

bf7668b

* handle custom lora preset/frequency * trunk fmt

Upgrade trunk (meshtastic#220)

45788ce

Co-authored-by: mverch67 <71137295+mverch67@users.noreply.github.com>

Revert "feat: handle custom lora preset/frequency (meshtastic#221)"

bb6e4a7

This reverts commit bf7668b.

restore changes for meshtastic#221

a6d5bd1

update to new protobufs (is_muted) (meshtastic#223)

3fb7c0e

docs: SD card explain file system (meshtastic#225)

19b7855

* Explain the file system to format to * Remove MBR section I believe MBR is not relevant at all * Add back MBR (also known as msdos)

add heltec-v4-tft code. (meshtastic#231)

28167c6

docs: Map compatibility information meshtastic#233 (meshtastic#235)

adf1d5f

* Map compatibility information * Add compatibility information for CrowPanel Advance HMI --------- Co-authored-by: Manuel <71137295+mverch67@users.noreply.github.com>

Upgrade trunk (meshtastic#222)

3bf3322

Co-authored-by: mverch67 <71137295+mverch67@users.noreply.github.com>

Merge branch 'master' into JC4827W543C

65c6a79

Fix init_cmds array size for Panel_NV3041A

d33c98d

see https://github.com/lovyan03/LovyanGFX/blob/2e0dc974a9b6521bf155afb53a9a92a623a60803/src/lgfx/v1/panel/Panel_NV3041A.hpp#L60

Merge pull request meshtastic#188 from meshtastic/JC4827W543C

4fb5f24

feat: Support 4.3" TFT display JC4827W543C

add time zone offset (meshtastic#242)

39c62eb

Upgrade trunk (meshtastic#236)

d8afe17

Co-authored-by: mverch67 <71137295+mverch67@users.noreply.github.com>

feat: new chats at top (meshtastic#243)

2746a1c

* add time zone offset * reverse order new chats

ericlewis added 5 commits September 17, 2026 18:07

fix(ui): scroll message history with the encoder

6d9be74

fix(ui): send messages after automatic period insertion

ca1016d

refactor(ui): remove timestamps from message bubbles

766a435

fix(ui): size message bubbles with the displayed font

4381db6

feat(pager): include core keyboard and landscape support

c9ddf6c

This was referenced Sep 18, 2026

fix(pager): complete native input and conversation controls #405

Open

fix(pager): integrate the native plugin UI and live settings meshtastic/firmware#11888

Draft

ericlewis marked this pull request as ready for review September 18, 2026 02:07

Copilot AI lite review requested due to automatic review settings September 18, 2026 02:07

ericlewis marked this pull request as draft September 18, 2026 02:20

Copilot AI reviewed Sep 18, 2026

View reviewed changes

ericlewis added 10 commits September 17, 2026 22:42

fix(pager): improve physical input and conversation behavior

702b08b

Prepared offline from e9c8eee.

fix(pager): share plugin styles and platform compatibility

6658e72

Prepared offline from e9c8eee.

refactor(pager): use coherent dashboard and conversation rows

81ea5e4

Prepared offline from e9c8eee.

feat(pager): display live local GPS receiver state

302d799

Prepared offline from e9c8eee.

merge(pager): integrate PR 405 source partition

b44c366

Prepared offline from e9c8eee.

merge(pager): integrate PR 406 source partition

b4e9278

Prepared offline from e9c8eee.

merge(pager): integrate PR 409 source partition

91f7d59

Prepared offline from e9c8eee.

fix(pager): improve physical input and conversation behavior

312f70c

Reconcile the published contribution with the native Pager plugin branch. Preserve the existing PR history and the cumulative dependency stage.

refactor(pager): use coherent dashboard and conversation rows

1560d6f

Reconcile the published contribution with the native Pager plugin branch. Preserve the existing PR history and the cumulative dependency stage.

feat(pager): display live local GPS receiver state

72ab933

Reconcile the published contribution with the native Pager plugin branch. Preserve the existing PR history and the cumulative dependency stage.

ericlewis changed the base branch from master to pager September 18, 2026 02:58

ericlewis added 2 commits September 17, 2026 23:00

merge(pager): preserve cumulative PR ancestry for meshtastic#406

8830a7b

Retain the published PR head and the preceding cumulative PR as parents. Keep the intended feature-stage tree unchanged.

merge(pager): preserve cumulative PR ancestry for meshtastic#409

25089ee

Retain the published PR head and the preceding cumulative PR as parents. Keep the intended feature-stage tree unchanged.

ericlewis mentioned this pull request Sep 18, 2026

refactor(pager): unify dashboard, node and channel rows #406

Open

ericlewis changed the title ~~feat(ui): display live local GPS receiver status~~ feat(pager): show live local GPS receiver status Sep 18, 2026

This was referenced Sep 18, 2026

feat(pager): share settings editors and apply live UI updates #407

Open

feat(pager): add map controls, caching and tile status #408

Open

ericlewis marked this pull request as ready for review September 18, 2026 03:02

Copilot started reviewing on behalf of ericlewis September 18, 2026 03:18 View session

Navigation Menu

Uh oh!

feat(pager): show live local GPS receiver status - #409

feat(pager): show live local GPS receiver status#409
ericlewis wants to merge 216 commits into
meshtastic:pagerfrom
ericlewis:codex/local-gps-status

ericlewis commented Sep 17, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

17 participants

Uh oh!

Conversation

ericlewis commented Sep 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Implementation

Testing

Risks

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

17 participants

ericlewis commented Sep 17, 2026 •

edited

Loading