Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Respect
sepwhen normalizing the C/POSIX locale aliases.Locale.parse("C", sep="-")andLocale.parse("POSIX", sep="-")currently fail because alias normalization buildsen_US_POSIX, which is then parsed using-. The explicit canonical inputLocale.parse("en-US-POSIX", sep="-")succeeds.Build the alias with
sep.join(("en", "US", "POSIX"))instead. This preserves the default underscore behavior and allows the supported hyphen separator. PublicLocale.negotiate(["C"], ["C"], sep="-")follows the repaired path too.This is a small follow-up to #1340. It does not change encoding/modifier handling or make C/POSIX and their canonical spellings interchangeable availability entries during negotiation.
Validation
Linux, CPython 3.12.14:
The skips and expected failures are pre-existing. Windows, macOS, other supported Python versions, and hosted CI have not been run for this patch.
AI assistance: implementation, tests, and this description were prepared with OpenAI assistance.