Skip to content

Respect custom separators for C/POSIX locale aliases #1360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PDGGK wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Respect custom separators for C/POSIX locale aliases #1360

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion babel/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,7 +364,7 @@ def parse(
# C/POSIX is not a CLDR language. Same mapping default_locale uses.
posix_stem = identifier.partition(".")[0]
if posix_stem.upper() in {"C", "POSIX"}:
identifier = "en_US_POSIX"
identifier = sep.join(("en", "US", "POSIX"))

parts = parse_locale(identifier, sep=sep)
input_id = get_locale_identifier(parts)
Expand Down
12 changes: 9 additions & 3 deletions tests/test_core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,10 +56,16 @@ def test_default_locale(monkeypatch):
assert default_locale() == 'en_US_POSIX'


def test_locale_parse_accepts_c_and_posix():
@pytest.mark.parametrize('sep', ['_', '-'])
@pytest.mark.parametrize('value', ['C', 'c', 'POSIX', 'posix', 'C.UTF-8', 'C.utf8', 'POSIX.UTF-8'])
def test_locale_parse_accepts_c_and_posix(value, sep):
expected = Locale.parse('en_US_POSIX')
for value in ['C', 'c', 'POSIX', 'posix', 'C.UTF-8', 'C.utf8', 'POSIX.UTF-8']:
assert Locale.parse(value) == expected
assert Locale.parse(value, sep=sep) == expected


@pytest.mark.parametrize('value', ['C', 'POSIX'])
def test_locale_negotiate_c_and_posix_custom_separator(value):
assert Locale.negotiate([value], [value], sep='-') == Locale.parse('en_US_POSIX')


def test_default_locale_multiple_args(monkeypatch):
Expand Down