Make ResolvableType.isInstance respect AOP proxies - #37365
Closed
Asthenia0412 wants to merge 1 commit into
Closed
Asthenia0412 wants to merge 1 commit into
Asthenia0412 wants to merge 1 commit into
Conversation
Use ClassUtils.getUserClass() to unwrap CGLIB proxies so that the target class's generic type information is available for assignability checks. For JDK dynamic proxies, where the target class's generics are erased on the proxy class, fall back to a raw type check against the interfaces implemented by the proxy. Closes spring-projectsgh-37049
spring-projects-issues
added
the
status: waiting-for-triage
sbrannen
added
status: declined
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Currently,
ResolvableType::isInstanceusesobj.getClass()directly, which does not account for AOP proxies:$$and the generic type information should be resolved against the target user class rather than the proxy subclass.List<String>) fails even though the proxy implements the corresponding interface.Changes
ResolvableType.isInstance(Object)now usesClassUtils.getUserClass(obj)to unwrap CGLIB proxies before the assignability check.resolve().isInstance(obj)).This makes
isInstanceconsistent with the rest of Spring's proxy handling (e.g.AbstractBeanFactory.isTypeMatch) and fixes the case described in the issue where a JDK proxy of a parameterized type was not detected as an instance.Related Issue
ResolvableType::isInstanceshould respect AOP proxy #37049