Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
import java.lang.reflect.Method;
import java.lang.reflect.Parameter;
import java.lang.reflect.ParameterizedType;
import java.lang.reflect.Proxy;
import java.lang.reflect.Type;
import java.lang.reflect.TypeVariable;
import java.lang.reflect.WildcardType;
Expand Down Expand Up @@ -246,7 +247,20 @@ public Class<?> toClass() {
* @see #isAssignableFrom(Class)
*/
public boolean isInstance(@Nullable Object obj) {
return (obj != null && isAssignableFrom(obj.getClass()));
if (obj == null) {
return false;
}
Class<?> userClass = ClassUtils.getUserClass(obj);
if (isAssignableFrom(userClass)) {
return true;
}
// For JDK dynamic proxies, the target class's generic type information
// is not available on the proxy class, so fall back to a raw type check.
if (Proxy.isProxyClass(userClass)) {
Class<?> resolved = resolve();
return (resolved != null && resolved.isInstance(obj));
}
return false;
}

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
import java.lang.reflect.Method;
import java.lang.reflect.Parameter;
import java.lang.reflect.ParameterizedType;
import java.lang.reflect.Proxy;
import java.lang.reflect.Type;
import java.lang.reflect.TypeVariable;
import java.lang.reflect.WildcardType;
Expand All @@ -51,6 +52,7 @@
import org.mockito.junit.jupiter.MockitoExtension;

import org.springframework.core.ResolvableType.VariableResolver;
import org.springframework.cglib.proxy.Enhancer;
import org.springframework.util.MultiValueMap;

import static org.assertj.core.api.Assertions.assertThat;
Expand Down Expand Up @@ -1065,6 +1067,32 @@ void isAssignableFromForClassAndClass() {
assertThat(stringType.isInstance(new StringBuilder("a StringBuilder"))).isFalse();
}

@Test
void isInstanceWithProxy() {
// CGLIB proxy: getUserClass() should unwrap the generated subclass
Enhancer enhancer = new Enhancer();
enhancer.setSuperclass(ExtendsList.class);
enhancer.setCallback((org.springframework.cglib.proxy.MethodInterceptor)
(obj, method, args, proxy) -> (method.getName().equals("size") ? 0 : proxy.invokeSuper(obj, args)));
Object cglibProxy = enhancer.create();

assertThat(ResolvableType.forClass(List.class).isInstance(cglibProxy)).isTrue();
assertThat(ResolvableType.forClass(ArrayList.class).isInstance(cglibProxy)).isTrue();
assertThat(ResolvableType.forClass(ExtendsList.class).isInstance(cglibProxy)).isTrue();
assertThat(ResolvableType.forClassWithGenerics(List.class, CharSequence.class).isInstance(cglibProxy)).isTrue();
assertThat(ResolvableType.forClass(Set.class).isInstance(cglibProxy)).isFalse();

// JDK dynamic proxy: implements the interface directly; generics are
// erased on the proxy class, so we fall back to the raw type check.
Object jdkProxy = Proxy.newProxyInstance(getClass().getClassLoader(),
new Class<?>[] { List.class }, (proxy, method, args) -> (method.getName().equals("size") ? 0 : null));

assertThat(ResolvableType.forClass(List.class).isInstance(jdkProxy)).isTrue();
assertThat(ResolvableType.forClass(Collection.class).isInstance(jdkProxy)).isTrue();
assertThat(ResolvableType.forClassWithGenerics(List.class, String.class).isInstance(jdkProxy)).isTrue();
assertThat(ResolvableType.forClass(Set.class).isInstance(jdkProxy)).isFalse();
}

@Test
void isAssignableFromCannotBeResolved() throws Exception {
ResolvableType objectType = ResolvableType.forClass(Object.class);
Expand Down